Repository navigation
fix: handle empty YAML locale files gracefully - #32
Merged
Merged
Conversation
kainstar
force-pushed
the
fix/handle-empty-locale-files
branch
from
May 11, 2026 03:04
8ef1d08 to
104fc9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a locale file is empty,
js-yaml'sload()returnsnullinstead of an object. Thisnullvalue is then passed directly to eithersetProperty(whennamespaceResolutionis enabled) or used asresBundle[lang](when it isn't). In both cases, a subsequentmerge()call can silently discard previously loaded content for that locale — i.e. if a locale directory contains both a populated file and an empty file with the same namespace, the empty file'snullresult can overwrite the populated one.Fix
Add a
?? {}fallback afterloadAndParse()so that empty files are treated as empty objects, leaving all other locale content unaffected.