-
Notifications
You must be signed in to change notification settings - Fork 511
feat: windows support [WIP] #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JalinWang
wants to merge
52
commits into
main
Choose a base branch
from
feat/win-compilation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,306
−807
Draft
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
7abb9e2
fix some
JalinWang c74f276
fix platform related
JalinWang 7fb10c4
hnsw VLAs
JalinWang 72f7214
hnsw sparse VLAs
JalinWang 89f02f5
flexible array member
JalinWang 8dc698b
type define
JalinWang 5521744
vla
JalinWang 88de5da
vla + uint8_t
JalinWang 8b3b3ef
__VA_ARGS__
JalinWang e8dc871
iota
JalinWang 673cf8e
ssize
JalinWang 431b541
sum4
JalinWang 66a8c56
fixup! hnsw VLAs
JalinWang 28d8c68
win header, file/time/sleep implement
JalinWang 3255327
func overload
JalinWang 228dfae
vla
JalinWang 402f2a1
TODO: should just support std::uniform_int_distribution<int8_t> inste…
JalinWang fb8511f
uint -> unsigned int
JalinWang 828e457
TODO: unknown reason
JalinWang 83a6423
TODO: skip tests
JalinWang c26de94
TODO: may revert
JalinWang 60da06e
TODO: rocksdb can't find lz4, could be optimized
JalinWang 3a267a0
third party Cmakelist: naming, compiling options
JalinWang c575663
TODO: designated init & c++ 20, may revert
JalinWang 539dc20
fix compiler options
JalinWang c92a51c
TODO: ignore some warning
JalinWang de9724b
TODO: to verify sparsehash's patch
JalinWang 3dab143
msvc debug will validate the boundary
JalinWang 52170b9
fix -1UL: On MSVC, unsigned long is 32-bit, so -1UL is 0xFFFFFFFF no…
JalinWang 47df026
fix flexible structure
JalinWang 1f87aa7
TODO: verify the fix of mmap alignment
JalinWang d9abe33
fix ctest failure by storage.close
JalinWang 689bb04
fix mutex by atomic: TestDumpIndexAndAdd test uses mutex.unlock() fro…
JalinWang 9b7321f
storage close
JalinWang d4d4a0b
TODO: unify the file cleanup of UTs
JalinWang 9133a76
TODO: currently replace dll by static to support indexFactory registe…
JalinWang 938e5a5
ignore more
JalinWang 6fb2707
fix antlr4 release
JalinWang 0e427a2
fix: gtest link warning
JalinWang 1948e39
revert c++20
JalinWang 7a5cfb6
platform related code refactor
JalinWang ed57793
buffer manager cleanup to avoid ctest failure
JalinWang 5c61212
refactor: file remove/test setup
JalinWang c6e5012
fix
JalinWang a7e5190
fix memory limit
JalinWang e7bbbfe
fix segment_helper_test
JalinWang e9e9c5d
Merge branch 'main' into feat/win-compilation
JalinWang 5c89b6e
fix write_recovery_test
JalinWang 62683bf
fix __m64
JalinWang cda7187
fix linux ut
JalinWang 26085af
fix write_recovery_test on linux
JalinWang 6795a6c
format
JalinWang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broad narrowing-conversion warnings suppressed without fix
/wd4267(conversion fromsize_tto a smaller type) and/wd4244(general type narrowing) are silently disabled with a comment acknowledging they need to be resolved. These two warnings regularly surface real runtime bugs (e.g.,size_t→inttruncation on 64-bit data, unintended float→int narrowing). Leaving them suppressed while the PR is merged makes it easy for future changes to introduce silent truncation bugs that are never caught.Consider replacing the blanket suppression with targeted
#pragma warning(suppress: ...)at the specific call sites that are genuinely safe, rather than disabling them project-wide.