Repository navigation
docs(mcp): use recorded MCP tool names and document mocked server behavior - #339
Merged
Merged
Conversation
…avior tool_called compares names exactly, and Claude Code, Codex, and Qoder CLI record MCP tools as mcp__<server>__<tool>. The server::tool examples in the writing guide and the skill-upper judge reference could never match. Also list how a tool_responses mock behaves: stdio only, started with node, one default response per tool, generic tool descriptions, and an error for undeclared tools.
karanb192
requested review from
JHWang-1997,
hittyt and
zpzjzj
as code owners
October 25, 2026 16:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Karan Bansal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tool_calledexamples in the writing guide useserver::toolnames (github::create_pull_request,project-mgmt::create_publish_plan_simple).tool_calledcompares names exactly, and Claude Code, Codex, and Qoder CLI record MCP tools asmcp__<server>__<tool>, so a rule copied from these examples never matches. The skill-upper judge reference has the same example, so agents that write evals with skill-upper copy it too.This PR switches the examples to the recorded form and adds a short list of how a
tool_responsesmock behaves.Related issues
None. Docs-only fix, so I went straight to a PR as CONTRIBUTING allows.
Changes
docs/guide/writing-evals.mdanddocs/zh/guide/writing-evals.md:tool_calledexamples usemcp__github__create_pull_requestandmcp__project-mgmt__create_publish_plan_simple.mcp__<server>__<tool>form.node, which must be onPATH(skill-up sets up Node.js only when it installs a Node-based engine CLI itself); onedefaultresponse per tool; generic tool description and open input schema; an error for undeclared tools.skills/skill-upper/references/judge-types.md: the same example fix plus a one-line note.Test plan
make testpassesmake verifypasses (fmt + vet + lint)npm run docs:buildpassescodexMCPToolNameininternal/agent/codex.go, the Qoder stream fixture ininternal/agent/qodercli_test.go, ande2e/testdata/sandbox-mcp, which already usesmcp__agent-sandbox__.... The Claude Code adapter passes the stream name through, and Claude Code names MCP toolsmcp__<server>__<tool>(Claude Code MCP docs).Notes for reviewers
internal/judge/rule_based_test.goalone. It usesgithub::...names on synthetic transcripts and only tests exact matching.{{params...}}breaks the VitePress build, so the template bullet points to the example'snamefield instead.