Repository navigation
fix(deps): unblock Go 1.26 and DSH dependency upgrades - #331
Merged
Merged
Conversation
zpzjzj
marked this pull request as ready for review
October 21, 2026 01:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining dependency updates fail because the Go modules now require Go 1.26 while workflows select Go 1.25, and DSH 0.1.5-rc.3 requires cordis 4.0.2 exactly while the grouped update selects 4.0.4.
Consolidate the OpenAI SDK 3.77.0, OpenTelemetry 1.47.0, and DSH 0.1.5-rc.3 updates. Align all Go workflows, build metadata, and source-build documentation with Go 1.26. Keep cordis at 4.0.2, regenerate the lockfile, and ignore only the incompatible cordis 4.0.4 update. Replace test pointer helpers with Go 1.26 new expressions as required by the existing modernize linter; assertions and lint rules are unchanged.
Supersedes #327, #310, and #298. Keep those PRs open until this replacement is merged.
Validation: make fmt, make verify (0 issues), go build ./..., go mod verify, deterministic E2E, 38 DSH tests, npm dependency-tree validation, and 14 GitHub Action adapter tests passed. make test passed (22 Codex plugin tests, 60 deterministic Skill regressions, and all Go race tests). This cloud container uses tail as PID 1 and does not reap orphaned processes; the process-cleanup regression passes three consecutive runs under a local Linux subreaper, and the full suite passed under the same wrapper without changing or skipping tests.
GitHub validation: CI (including CI Gate), Extended CI (Windows E2E, Docker integration, and GoReleaser snapshot), CodeQL (Go/Python/Actions), Docs, Release PR checks, and Workflow Security all passed on bb1272c.