Repository navigation
feat(evaluator): run sequential judges in the shared case runtime - #315
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zpzjzj
force-pushed
the
feat/docker-judge-snapshots
branch
from
October 13, 2026 09:50
3796e6e to
7bed79b
Compare
zpzjzj
force-pushed
the
feat/docker-judge-snapshots
branch
from
October 14, 2026 02:33
7bed79b to
f3aa2b8
Compare
5 tasks done
zpzjzj
force-pushed
the
feat/docker-judge-snapshots
branch
2 times, most recently
from
October 16, 2026 03:05
13df20f to
918952a
Compare
JHWang-1997
requested changes
Oct 16, 2026
JHWang-1997
left a comment
Collaborator
There was a problem hiding this comment.
Reproduced an order-dependent P2 regression in shared-runtime judging: a legacy OpenCode judge can retain the preceding independent judge’s endpoint instead of its resolved runner connection. Verified actual HTTP request routing with OpenCode 1.14.24; the same reproduction routes correctly on base 87f86b5. Details and reproduction are in the inline comment.
zpzjzj
force-pushed
the
feat/docker-judge-snapshots
branch
from
October 20, 2026 02:40
fb6981c to
83583ba
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the evaluated Agent once, then execute named judges sequentially in the same case runtime (
none, Docker or OpenSandbox). Each Agent judge starts a fresh session; timeouts, verdicts and archived materials remain separate by judge ID. Remove judge Snapshot/fork support and retain normal case cleanup.Filesystem mutations, installed tools, services, volumes, environment and network policy remain shared. Later judges still run after an earlier judge FAIL/ERROR; case cancellation skips pending members. Separate sessions do not provide filesystem or external-service isolation.
Changes and scope
Dependencies
Based on main at
6d121cb02970e355fe5ea00c55a215f09a8542b1, including #314's independent-engine/provider support and #323's bounded GoReleaser build concurrency. The PR contains only shared-runtime orchestration, Snapshot removal, consolidated regressions/documentation, and the OpenCode judge connection-order fix. #316 is closed and its tests/docs are included here.Part of #308. Filesystem-isolation-specific acceptance remains outside this shared-runtime design, so #308 stays open.
Validation
make fmt verify test build e2e test-actionpassed on83583ba4dffd0c138d727b5e8336f22e2ab83095, including race tests, plugin tests and Skill regression scripts. E2E-tag lint passed with zero findings. The real OpenCode 1.14.24 loopback HTTP order regression also passed in both directions. All standard CI checks passed for this exact SHA: CI, Extended CI, CodeQL, docs, and release tooling.The writing-evals guide includes reproduction commands for the shared environment, real provider calls and configuration-only readback.
Follow-up: OpenCode judge connection ordering
Fixed the review regression where a legacy
judge.modelmember could reuse the preceding independent OpenCode judge's endpoint. Every OpenCode Agent judge now reapplies its resolved provider connection before invocation; independent-engine install/preflight and shared runtime/fresh-session behavior are retained.make fmt verify test build e2e test-action, including race tests, passed. E2E-tag lint passed with zero issues. All standard CI checks passed for83583baafter rebase onto main with fix(ci): bound GoReleaser build concurrency on self-hosted runners #323 (runs linked above); live-service/model-gated skips are not counted as service validation.Reproduce the local HTTP test with
SKILL_UP_OPENCODE_ORDER_E2E=1 go test -count=1 -tags e2e -run '^TestOpenCodeJudgeConnectionOrder$' -v ./e2eand OpenCode installed.