fix(search-account): copy index scope#706
Open
loicsay wants to merge 1 commit into
Open
Conversation
loicsay
force-pushed
the
fix/search-account-copy-index
branch
from
2298e24 to
1e3aeda
Compare
loicsay
force-pushed
the
fix/search-account-copy-index
branch
from
1e3aeda to
0adc702
Compare
|
It looks like he |
mehmetaligok
pushed a commit
that referenced
this pull request
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Taking scope into account to copy rules, synonyms and settings only when there's no scope. If one (or multiple) scope options are passed, copy the index depending on the parameters.
What problem is this fixing?
scopeoption passed tosearch.NewAccount().CopyIndex(...)is ignored.