fix(web): simplify teacher evidence details - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Simplify the teacher-facing Evidence Desk report based on the reviewed walkthrough: retain only one clear, accessible ‘Show exact contributing evidence’ disclosure with useful exact attempt/session result, answer, and timing content; remove the entire Additional evidence area and any teacher-facing additional cause, rule, quality-detail, or expandable technical-provenance UI. Keep rank, priority, confidence, conversation opener, student comparison, and a concise deterministic-fallback cue. Make the smallest frontend-only change, preserve backend scoring and data contracts, and verify responsive spacing and regression coverage.
What Changed
Risk Assessment
✅ Low: The frontend-only change conforms to the requested presentation, preserves scoring and application data contracts, and leaves only a minor non-functional simplification opportunity.
Testing
After resolving the isolated worktree’s missing dependencies, the focused Vitest regression passed and desktop/mobile browser checks demonstrated the simplified report end to end with useful exact attempt/session evidence, no additional or technical-provenance UI, and no horizontal overflow; reviewer-visible HTML and screenshots were captured and all worktree test artifacts were cleaned.
/var/folders/nt/rdk7cjs538l8zphln24q2k900000gn/T/no-mistakes-evidence/01KYT0NN5F6PGZEV8HBX4KW45J/evidence-desk-desktop-collapsed.png)/var/folders/nt/rdk7cjs538l8zphln24q2k900000gn/T/no-mistakes-evidence/01KYT0NN5F6PGZEV8HBX4KW45J/evidence-desk-desktop-expanded.png)/var/folders/nt/rdk7cjs538l8zphln24q2k900000gn/T/no-mistakes-evidence/01KYT0NN5F6PGZEV8HBX4KW45J/evidence-desk-mobile-expanded.png)Evidence: Interactive report rendered from changed components and production CSS
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
apps/web/app/board/lib/teacher-report-view.ts:68- After excluding additional-signal evidence, these single-element source arrays and their outer loops are redundant, while the adjacent comment still claims the helper combines evidence across several signals. Iterateevidence.exact.attemptsandevidence.exact.sessionsdirectly, retaining the maps for deduplication, and update the comment to describe dominant-signal evidence.✅ **Test** - passed
✅ No issues found.
git diff 6c8936396ccbcd294b8b46ea6792e9b5af49a40e..4f1516a9eb80ff40012f2d0eb278eac3c6a2a47e— confirmed the change is limited to four frontend/test filesnpm ci— installed locked dependencies after the initial Vitest command found no local installationnode_modules/.bin/vitest run apps/web/test/evidence-desk-rendering.test.ts— targeted rendering, accessibility, disclosure, copy-removal, and responsive regression coveragenode_modules/.bin/tsx .tmp-no-mistakes/evidence-render.tsx— rendered changed components and production CSS with injected additional evidence; verified one disclosure and exclusion of additional activity/provenancePlaywright WebKit at 1440×1200 — inspected and captured collapsed and expanded teacher-report statesPlaywright WebKit at 390×844 — inspected expanded report; verifiedscrollWidth === clientWidth === 390, one disclosure, and no forbidden additional/provenance textRemoved temporary dependencies, package build outputs, browser runtime, Playwright state, and evidence-generation harness from the worktree; retained only dedicated evidence files✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.