Increase ffmpeg thread queue size in recording script

[alexbelgium]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @alexbelgium, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and stability of the ffmpeg recording process used in the birdnet_recording.sh script. By increasing the thread queue size, the system gains a larger buffer for handling incoming audio streams, which can mitigate potential data loss or glitches. Additionally, the removal of the strict -xerror flag makes the recording more tolerant to non-critical errors, ensuring continuous operation even if minor problems arise during the process.

Highlights

• FFmpeg Configuration Update: The ffmpeg command within the birdnet_recording.sh script has been updated to include new parameters for improved stream handling.
• Increased Thread Queue Size: The -thread_queue_size 512 option has been added to the ffmpeg command. This change is intended to provide a larger buffer for incoming data, potentially improving stability and preventing issues with stream processing.
• Modified Error Handling: The -xerror option has been removed from the ffmpeg command. This adjustment means ffmpeg will no longer exit immediately upon encountering any error, allowing for more resilient recording in the face of minor issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the ffmpeg thread queue size, which should help with recording stability from network streams. However, the change also removes the -xerror flag. This is a significant change in error handling that could lead to silent recording failures, as ffmpeg might not exit on non-fatal errors, preventing the script's restart logic from triggering. I've recommended restoring this flag. Additionally, I've suggested replacing the hardcoded queue size with a configurable variable to improve maintainability.