Skip to content

Use legacy 1.21 for numpy - #155

Closed
alexbelgium wants to merge 1 commit into
mainfrom
patch-5
Closed

Use legacy 1.21 for numpy#155
alexbelgium wants to merge 1 commit into
mainfrom
patch-5

Conversation

@alexbelgium

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/server.py
os.environ['TF_CPP_MIN_LOG_LEVEL'] = '3'
os.environ['CUDA_VISIBLE_DEVICES'] = ''
np.set_printoptions(legacy="1.25")
np.set_printoptions(legacy="1.21")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Avoid invalid NumPy legacy flag

The new call np.set_printoptions(legacy="1.21") is not a supported value for the legacy keyword—NumPy only accepts None, '1.13' and (since 2.0) '1.25'. With any released NumPy, this line raises ValueError: legacy must be None or '1.13'/'1.25' during module import, so the server fails before any logic runs. If the intent was to preserve the 1.25 print behaviour under NumPy 2.0, the previous '1.25' string was the correct option.

Useful? React with 👍 / 👎.

@alexbelgium alexbelgium closed this Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant