fix(priorbank): guard non-array apiAccountDetails in convertAccounts#94
Closed
alex-mextner wants to merge 1 commit into
Closed
fix(priorbank): guard non-array apiAccountDetails in convertAccounts#94alex-mextner wants to merge 1 commit into
alex-mextner wants to merge 1 commit into
Conversation
PriorBank API returns null/non-array for apiAccountDetails at midnight UTC. Bumps ZenPlugins to 7b0513a1→896cf8fb (alex-mextner fork). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🔁 PR closed. Stage bot switched back to |
Owner
Author
|
Заменено develop-веткой в ZenPlugins — пиннится через #develop напрямую. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PriorBank plugin crashes at midnight UTC when the API returns a non-array value for
apiAccountDetails:Error is
failures:1, self-heals in 30 min, fires every night at 00:00 UTC.Fix
Added
Array.isArray()guard at the top ofconvertAccounts.Changes in ZenPlugins fork (
alex-mextner/ZenPlugins@896cf8fb):priorbank/converters.js: guard inconvertAccountspriorbank/__tests__/converters/accounts/convertAccountsGuard.test.js: 3 tests for null/undefined/object inputTest plan
jest --testPathPattern="plugins/priorbank"— 12 suites, 36 tests passts-standardclean on changed filestsc --noEmitpassesDepends on #93 (same ZenPlugins branch, stacked commit).
🤖 Generated with Claude Code