🐛 Fix message settlement, failed to open connections, and a few smaller bugs - #311
Merged
Merged
Conversation
aleksul
changed the title
aleksul
force-pushed
the
aleksul/fix-message-settlement
branch
from
September 12, 2026 01:35
060b507 to
aa846f5
Compare
Deploying repid with
|
| Latest commit: |
c226e2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d1ccfb3.repid.pages.dev |
| Branch Preview URL: | https://aleksul-fix-message-settleme.repid.pages.dev |
Coverage Report
105 files skipped due to complete coverage. |
aleksul
force-pushed
the
aleksul/fix-message-settlement
branch
2 times, most recently
from
September 12, 2026 15:43
81831b4 to
eb18090
Compare
aleksul
changed the title
Combine the per-broker settlement fixes into one change: NATS, SQS, Pub/Sub, Redis, and AMQP now reserve the settlement action synchronously before the first await of every ack/nack/reject/reply, making the check-and-set atomic in a single event loop. Concurrent settlements are deduplicated, keep-alive renewals cannot race settlements, and a settlement cancelled mid-RPC stays reserved so a second settlement is never issued. Only a real failure releases the reservation for a retry. - NATS: serialize settlement and reply operations (incl. DLQ fallback) - SQS: serialize settlement operations (incl. keep-alive renewal) - Pub/Sub: cancellation-safe control batcher operations - Redis: serialize settlement operations - AMQP: serialize disposition settlements - Kafka/in-memory: already reserve before awaiting; unchanged - Pub/Sub message layer simplified to plain reservation Additionally: in Kafka: drop the unused module-level logger
- Kafka: stop the producer when start() fails - Redis: close the client when ping() fails; catch real connection errors in retry/reclaim loops - AMQP: close the connection on failed connect and drop stale connections before reconnecting - Pub/Sub: only mark the broker connected after channel, protocol client and control batcher are all up; close the channel on failure - NATS: clear a stale client before reconnecting
aleksul
force-pushed
the
aleksul/fix-message-settlement
branch
from
September 12, 2026 15:53
eb18090 to
c226e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.