feat: use exoplayer, hybrid composition#27
Conversation
|
This PR makes a lot of changes as I actually intended it to go to a fork. But I'm leaving it open in case you're interested in accepting these changes. |
mertalev
force-pushed
the
feat/exoplayer
branch
from
68ea203 to
3f4afab
Compare
|
hey @mertalev thank you very much for your contribution! I really appreciate it. I'll review your code more closely and give you some more detailed feedback. regarding using ExoPlayer, i know it supports more formats, but what are other advantages of using it? the original plan for this package was to use only native APIs, not 3rd party dependencies, so i'm not sure if to include exoplayer or not. BTW I might ask you to split this PR into smaller ones, to make it easier to merge and review. but I'll let you know and give you a follow up on this. |
|
We had buffering issues with MediaPlayer. It sometimes took many seconds for it to start playing a remote video, and seeking could also take several seconds. Exoplayer is much smoother in that regard. Another thing is that using hybrid composition with MediaPlayer+VideoView always showed a black screen. Since hybrid composition is needed for HDR and works as expected with Exoplayer, it became the clear option. I can definitely shrink the PR down by removing the looping etc. |
…player) (#7) fix: Don't crash on Android if data source throws Exception See immich-app/immich#15230 (comment). So far, only java.lang.Error was caught, but HttpDataSource.InvalidResponseCodeException is a java.lang.Exception.
|
@mertalev sorry for the late reply, I didn't forget about your PR. you might have seen that I'm actively working on v3 of the plugin, and I have published a few dev releases. one of these releases includes using Expoplayer on Android. I took the code from your PR directly, and adapted it to the new implementation, which is a bit different. I'm still not sure about using hybrid composition and moving the looping logic to the native side. Could you please give the latest dev version (3.0.0.dev3) a try, and see if it fixes the issues you had? Thank you! |
|
@mertalev I've just published v3.0.0 stable, and I'd like to give you an update on your PR. Changes mentioned in your PR Description: Switched Android implementation from MediaPlayer to Exoplayer✅ done, available in v3. Changed rendering mode to hybrid composition for HDR support (matching iOS)I'll consider adding this in a future version. Added native support for looping playbackI'm still not sure if I like to have this implemented in the native side, as it complicates the logic. You've mentioned having issues with a Dart implementation, compared to the native one? Modified playback completion to only set "stopped" status in Dart without releasing video resourcesThis behaviour has changed with the new API, please have a look at it and see if works for you or not. Changed
|
4 participants
Description
This PR overhauls the Android implementation to use Exoplayer instead of MediaPlayer and changes the rendering mode to hybrid composition for HDR support (same as iOS). This allows for smoother playback and seeking as well as faster initialization. Additionally, I was unable to use hybrid composition with MediaPlayer's VideoView, but it works with Exoplayer without issue.
It also makes some other adjustments. Looping is now natively supported and managed as it worked better than handling it in Dart from my testing. Playback completion now only sets the "stopped" status in Dart without releasing video resources - this caused issues with Exoplayer.
onPlaybackEndedis only called when the video actually stops playing - looping does not fire this event. This removes the guesswork on the caller's side as to whether the UI should be updated or if the video is just going to start again.