[18.0][FIX] l10n_fr_einvocing: Only SIREN 1 and 2 are allowed to be added in sandbox SuperPDP env

[remi-filament]

Hi @alexis-via I have fixed a few errors found while testing.
To ease analysis, I made a commit per fix but I could group them in a single commit if you prefer.

Fixes #4 #19 and #20

[ak-git-bot]

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

[bguillot]

beside small change LGTM
Thanks for the fixes !

[bguillot]

You can remove this line as it is set in if/else

[remi-filament]

Thanks @bguillot I forgot it !

[remi-filament]

Rebased
Also content of #10 is part of this PR

[alexis-via]

Thank you very much for all those fixes. I integrated all of them in my last commit, except the change on the onboarding (I quoted your name in the commit). For some of them, I chose a different solution, in particular for the dependency on l10n_fr_business_document_import : I removed the call on _match_partner, which removed the need to depend on this module.
I hope my implementation of the fixes is ok for you.
I propose to close this PR, and open a new one if needed on a specific point.
Thanks again for your help on this testing/bugfix phase.

[remi-filament]

Thanks @alexis-via I just checked, all my fixes have been implemented but one.
The one changing optional_uri_params on res_company for authorization_code with SuperPDP. SuperPDP refuses any connection if SIREN is not 1 or 2 on sandbox so it makes sense for me to force to use SIREN = 000000001 when using sandbox and SuperPDP so that Authorization flow can be properly tested.

See : e191b5e
If you prefer I create another PR with only this commit ?

[alexis-via]

Yes, I didn't take this patch because I didn't understand it. So, what I understand now, is that you want to be able to test the SUPERPDP onbaording from a company where SIREN is not the SIREN of BurgerQueen nor Tricatel, but any SIREN, and the code would query with a SIREN different than the company's SIREN. Did I understand it correctly ?

[remi-filament]

Not sure, my issue was that when trying to create a new company with authorization code, Super PDP replied that only SIREN 000000001 or SIREN 000000002 could be created on sandbox instance.

Now when trying to connect with Le Filament SIREN + scheme = sandbox, I get the following reply from SuperPDP API :

{'error': 'invalid_request', 'error_description': 'No company found with these superpdp_company_number_scheme and superpdp_company_number.', 'state': 'vDcyEKQDiAY45mBmrQCuqpOJyP5h3S'}

Maybe I am missing something on this authorization code flow ?

[remi-filament]

Hi @alexis-via I removed all the fixes that you already implemented and kept only the missing one in this PR.

[flotho]

easy code review LGTM