fix(cluster): report leased ip inventory status#399
Conversation
Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR enhances the inventory service with leased-IP reserved/available accounting and reporting, integrates those checks into reservation handling, exposes leased-IP status in snapshots with unit tests, and adds an optional reclamation-window configuration wired through CLI, service, order messages, event logging, and dependency updates. ChangesLeased-IP Accounting and Reclamation Window
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
Signed-off-by: Artur Troian <troian@users.noreply.github.com> Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
go.mod (1)
351-355: ⚡ Quick winRemove OpenTelemetry version skew in go.mod
go.opentelemetry.io/otel/otel/metric/otel/traceare pinned to v1.41.0 whilego.opentelemetry.io/otel/sdk/otel/sdk/metricare pinned to v1.37.0, creating an avoidable mismatch.go.opentelemetry.io/otel v1.41.0 // indirect go.opentelemetry.io/otel/metric v1.41.0 // indirect go.opentelemetry.io/otel/sdk v1.37.0 // indirect go.opentelemetry.io/otel/sdk/metric v1.37.0 // indirect go.opentelemetry.io/otel/trace v1.41.0 // indirectBump
otel/sdk(andotel/sdk/metric) to match theotel*versions (or pinotel*to match the SDK).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` around lines 351 - 355, The go.mod has version skew between modules: go.opentelemetry.io/otel and otel/metric/trace are v1.41.0 while go.opentelemetry.io/otel/sdk and otel/sdk/metric are v1.37.0; update the sdk module lines (go.opentelemetry.io/otel/sdk and go.opentelemetry.io/otel/sdk/metric) to the matching v1.41.0 (or alternatively pin the other otel/* entries to v1.37.0) and then run go get or go mod tidy to reconcile dependencies so all otel packages use the same version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 13: The go.mod shows require github.com/cosmos/cosmos-sdk v0.53.6 but a
replace currently pins it to github.com/akash-network/cosmos-sdk
v0.53.5-akash.1, so the bump is being shadowed; update or remove the replace
entry that maps github.com/cosmos/cosmos-sdk =>
github.com/akash-network/cosmos-sdk v0.53.5-akash.1 (or change it to point to a
compatible v0.53.6 akash fork) so the require for v0.53.6 takes effect, then run
`go mod tidy` to verify effective version resolution.
---
Nitpick comments:
In `@go.mod`:
- Around line 351-355: The go.mod has version skew between modules:
go.opentelemetry.io/otel and otel/metric/trace are v1.41.0 while
go.opentelemetry.io/otel/sdk and otel/sdk/metric are v1.37.0; update the sdk
module lines (go.opentelemetry.io/otel/sdk and
go.opentelemetry.io/otel/sdk/metric) to the matching v1.41.0 (or alternatively
pin the other otel/* entries to v1.37.0) and then run go get or go mod tidy to
reconcile dependencies so all otel packages use the same version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2446aa22-79e9-49c1-8577-5502fac27638
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (9)
bidengine/config.gobidengine/order.gocluster/manager.gocluster/service.gocmd/provider-services/cmd/flags.gocmd/provider-services/cmd/run.goconfig.gogo.modservice.go
Signed-off-by: Joseph Chalabi <chalabi.joseph@gmail.com>
Description
Reports leased IP capacity in provider gRPC status through
cluster.inventory.leased_ip, using the chain-sdkakash.inventory.v1.ResourcePairadded in akash-network/chain-sdk#313.The provider maps the IP operator total pool to
capacityandallocatable, and maps confirmed in-use IPs plus unconfirmed reserved IPs toallocated. Consumers can useallocatable - allocatedas the remaining leased IP capacity for bid screening.Purpose of the Change
Related Issues
Notes for Reviewers
pkg.akt.dev/gois bumped tov0.2.12.LEASED_IPendpoint sequence numbers in the group spec viaGetEndpointQuantityOfResourceGroup.leased_ip.allocatable - leased_ip.allocated.