Ran into a segfault and some memory leaks. Fixed them and added a decorator. - #1
Open
otherwiseguy wants to merge 3 commits into
Open
Ran into a segfault and some memory leaks. Fixed them and added a decorator.#1otherwiseguy wants to merge 3 commits into
otherwiseguy wants to merge 3 commits into
Conversation
This also properly decrements PyObjects that are returned as new references and refactors a bit to reduce the idention level.
Also adds --log-file option and hacks around an issue where passing globals/locals to execfile breaks scripts that also parse arguments. I'll probably add an option later once I understand the original use case better.
Owner
|
Hi, I'm sorry this took me so long to notice your pull request. Can you please split it into individual PRs that handle one thing at at time? (On your end you'll want to move the commits to separate branches.) Also, can you tell me how to reproduce the segfault? Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried not to change any behavior, but went ahead and refactored a little to reduce the indentation level while also handling the Py_DECREFs for the newly returned references.