Skip to content

Revert setuptools constraint bump and restrict dependabot to subdir#225

Merged
webknjaz merged 2 commits into
aio-libs:masterfrom
bbhtt:bbhtt/rev-setuptools-bump
May 11, 2026
Merged

Revert setuptools constraint bump and restrict dependabot to subdir#225
webknjaz merged 2 commits into
aio-libs:masterfrom
bbhtt:bbhtt/rev-setuptools-bump

Conversation

@bbhtt
Copy link
Copy Markdown
Contributor

@bbhtt bbhtt commented May 11, 2026

What do these changes do?

Reverts an unintended setuptools constraint bump in pyproject.toml
and restrict dependabot to subdir to prevent it from happening again.

Are there changes in behavior for the user?

None

Related issue number

Ref: #207 (comment)

Checklist

  • I think the code is well written N/A
  • Unit tests for the changes exist N/A
  • Documentation reflects the changes N/A

@bbhtt bbhtt force-pushed the bbhtt/rev-setuptools-bump branch from 936f279 to befe143 Compare May 11, 2026 00:29
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label May 11, 2026
@bbhtt
Copy link
Copy Markdown
Contributor Author

bbhtt commented May 11, 2026

yamllint is broken it is perfectly valid YAML.

@bbhtt bbhtt force-pushed the bbhtt/rev-setuptools-bump branch from befe143 to 7240384 Compare May 11, 2026 00:41
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 11, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing bbhtt:bbhtt/rev-setuptools-bump (7079c7d) with master (61d59b5)

Open in CodSpeed

@webknjaz
Copy link
Copy Markdown
Member

yamllint is broken

It's not broken, it's configured.

@webknjaz
Copy link
Copy Markdown
Member

unintended setuptools constraint bump in pyproject.toml

Could you link to the discussion that says so?

Comment thread CHANGES/207.packaging.rst Outdated
@webknjaz
Copy link
Copy Markdown
Member

unintended setuptools constraint bump in pyproject.toml

Could you link to the discussion that says so?

Ah, found it in the commit: #207 (comment).

Comment thread CHANGES/207.packaging.rst
@bbhtt bbhtt force-pushed the bbhtt/rev-setuptools-bump branch from 3590252 to c9a8a1d Compare May 11, 2026 13:26
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented May 11, 2026

@bbhtt you can add dependabot to https://github.com/aio-libs/propcache/blob/master/docs/spelling_wordlist.txt.

Also, I just now noticed that the change log looks like a TODO-list or a Git log. Instead of the imperative mood of things to implement, let's update it to what's changed since the previous release by using the past tense of a present comparison ("X now does Y", "X has been changed to Y", "Updated X to Y").

This reverts commit d02f2dc.

This was automatically bumped by dependabot in #207 but it is incorrect
and pyproject.toml constraints should only be bumped if there is
an actual need for it. The next commit will try to restrict
dependabot from making these unintentional updates.
@bbhtt bbhtt force-pushed the bbhtt/rev-setuptools-bump branch from c9a8a1d to 39a36fa Compare May 11, 2026 13:56
This is where dependency requirements should be bumped and this should
prevent it from making unintended changes like in #207
@bbhtt bbhtt force-pushed the bbhtt/rev-setuptools-bump branch from 78fe8da to 7079c7d Compare May 11, 2026 13:59
@bbhtt
Copy link
Copy Markdown
Contributor Author

bbhtt commented May 11, 2026

Done and changed to has been but git fetch is failing due to 500

@webknjaz webknjaz closed this May 11, 2026
@webknjaz webknjaz reopened this May 11, 2026
@webknjaz webknjaz enabled auto-merge (squash) May 11, 2026 20:56
@webknjaz webknjaz disabled auto-merge May 11, 2026 20:57
@webknjaz webknjaz enabled auto-merge (squash) May 11, 2026 20:57
@webknjaz webknjaz merged commit 577a2ce into aio-libs:master May 11, 2026
70 of 73 checks passed
@bbhtt bbhtt deleted the bbhtt/rev-setuptools-bump branch May 11, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants