Skip to content

Discussion should be in GH Org#217

Open
gundalow wants to merge 4 commits into
aio-libs:masterfrom
gundalow:docs-links
Open

Discussion should be in GH Org#217
gundalow wants to merge 4 commits into
aio-libs:masterfrom
gundalow:docs-links

Conversation

@gundalow
Copy link
Copy Markdown
Contributor

@gundalow gundalow commented May 8, 2026

What do these changes do?

The Google Group has been archived, GitHub Discussions are not enabled in this repo.

Just a few small docs updates I noticed when looking round the repo

Are there changes in behavior for the user?

N/A

Related issue number

N/A

Checklist

  • I think the code is well written: N/A
  • Unit tests for the changes exist: N/A
  • Documentation reflects the changes

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing gundalow:docs-links (37da8a5) with master (61d59b5)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (61d59b5) to head (37da8a5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          17       17           
  Lines         881      881           
  Branches       44       44           
=======================================
  Hits          861      861           
  Misses         12       12           
  Partials        8        8           
Flag Coverage Δ
CI-GHA 97.72% <ø> (ø)
MyPy 92.16% <ø> (ø)
OS-Linux 97.49% <ø> (ø)
OS-Windows 94.53% <ø> (ø)
OS-macOS 94.53% <ø> (ø)
Py-3.10.11 92.71% <ø> (ø)
Py-3.10.20 94.53% <ø> (ø)
Py-3.11.15 96.12% <ø> (ø)
Py-3.11.9 94.30% <ø> (ø)
Py-3.12.10 94.30% <ø> (ø)
Py-3.12.13 96.12% <ø> (ø)
Py-3.13.13 96.12% <ø> (ø)
Py-3.13.13t 96.12% <ø> (ø)
Py-3.14.4 96.10% <ø> (ø)
Py-3.14.4t ?
Py-3.14.5t 96.10% <ø> (?)
Py-pypy3.10.16-7.3.19 78.13% <ø> (ø)
VM-macos-latest 94.53% <ø> (ø)
VM-ubuntu-latest 97.49% <ø> (ø)
VM-windows-11-arm 94.30% <ø> (ø)
VM-windows-latest 94.53% <ø> (ø)
pytest 97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The Google Group has been archived, GitHub Discussions are not enabled
in this repo
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label May 8, 2026
Copy link
Copy Markdown
Member

@Vizonex Vizonex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Let's see what others have to say about this.

@Vizonex Vizonex mentioned this pull request May 8, 2026
3 tasks
- name: >-
[🎉 NEW 🎉]
🤷💻🤦 GitHub Discussions
url: https://github.com/aio-libs/propcache/discussions
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project-specific discussions are in-repo. The org-global announcements would be in the org discussions. So this doesn't need to be changed in the form.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something else I read implied people should go to the Org wide Discussion area.

Though per-repo makes sense, I'll update

Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't send people to the org-global discussions in general. Most things should be attached to repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants