Repository navigation
Prepare the CRAN resubmission of turfLP 0.2.0 - #10
Merged
Merged
Conversation
…ease The CI TeX setup fails in the index step of the R-devel manual, while win-builder built the R-devel manual without problems, so the R-devel check is win-builder's.
The CRAN pretest flagged the lunchbags example (6.5 s). It now solves one portfolio size, and the turf() example uses a smaller simulated data set. cran-comments.md explains the resubmission.
…e example timing The single summary said one "New submission" note for every environment. The win-builder note is incoming feasibility (new submission and the four flagged words), the as-cran CI note is the HTML manual check (no Tidy or V8 on the runner), and the matrix jobs have no notes. The slowest example takes about 1.7 s, not under 1.5 s. The package is new, not a first submission.
john-aigora
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the CRAN resubmission of turfLP 0.2.0 after the first incoming pretest.
lunchbagsnow solves one portfolio size (it took 6.5 s on Debian), and theturf()example uses a smaller simulated data set. Every example runs in under 2 s on a laptop.cran-comments.md: a Resubmission section explains both pretest notes, and the check results are reported per environment (win-builder R-devel, the as-cran CI job with the PDF manual, the OS matrix).The resubmitted tarball (built from 1a4a482) cleared the automated pretests and is waiting for CRAN's manual review. These documentation fixes do not change the package.