Skip to content

Conversation

@neelay-aign
Copy link
Collaborator

No description provided.

@atlantis-platform-engineering
Copy link

Plan Error

running git merge -q --no-ff -m atlantis-merge FETCH_HEAD: Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
Auto-merging pyproject.toml
CONFLICT (content): Merge conflict in pyproject.toml
Auto-merging src/aignostics/CLAUDE.md
CONFLICT (content): Merge conflict in src/aignostics/CLAUDE.md
Auto-merging src/aignostics/cli.py
CONFLICT (content): Merge conflict in src/aignostics/cli.py
Auto-merging src/aignostics/utils/CLAUDE.md
CONFLICT (content): Merge conflict in src/aignostics/utils/CLAUDE.md
Auto-merging src/aignostics/utils/__init__.py
CONFLICT (content): Merge conflict in src/aignostics/utils/__init__.py
Auto-merging src/aignostics/utils/_mcp.py
CONFLICT (add/add): Merge conflict in src/aignostics/utils/_mcp.py
Auto-merging tests/aignostics/cli_test.py
CONFLICT (content): Merge conflict in tests/aignostics/cli_test.py
Auto-merging tests/aignostics/utils/mcp_test.py
CONFLICT (add/add): Merge conflict in tests/aignostics/utils/mcp_test.py
Auto-merging uv.lock
CONFLICT (content): Merge conflict in uv.lock
Automatic merge failed; fix conflicts and then commit the result.
: exit status 1

@neelay-aign neelay-aign force-pushed the task/BE-5766-create-papi-heta-tools branch from b718c11 to 34e633f Compare February 3, 2026 05:21
@neelay-aign neelay-aign force-pushed the task/BE-5766-create-papi-heta-tools branch from 221f3e1 to ab631d9 Compare February 3, 2026 11:02
Client._api_client_uncached = None


def _retry_on_auth_failure(func: Callable[P, R]) -> Callable[P, R]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible for this function to retry indefinitely if something goes really wrong and auth keeps failing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think so, at least not due to the decorator implementation. The decorator only clears the cached token and then retries the wrapped function once.
There could be a hang if something goes wrong in authentication when a Client() is instantiated but that wouldn't be due to this retry.


lines = [header, separator]
for i, row in enumerate(rows):
if i >= MAX_SQL_RESULT_ROWS:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make more sense to add LIMIT to the sql query?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what I wanted to do is have a way to return limited number of rows in the tool result but also tell the LLM that there were more rows in the output of the SQL query. So that the LLM can "know" that there were more rows which couldn't be returned (say if the query was returning 200k rows) and that it needs to take a different approach.
But there's a better way to do this. I'll change this with some other changes I'll push in a short while about the handling of tool results. I realized we need some safeguards in the output of the visualize calls.
Thanks 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been pushed. Needed to do some more around the outputs of tool calls.

@neelay-aign neelay-aign force-pushed the task/BE-5766-create-papi-heta-tools branch from ddb2128 to 3dc9e69 Compare February 4, 2026 15:09
@neelay-aign neelay-aign merged commit d57c928 into task/BE-5757-central-mcp-server-python-sdk Feb 4, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants