fix(adapter): isolate nested OpenClaw skills - #71
Merged
Conversation
limaronaldo
commented
Jul 24, 2026
limaronaldo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code review verdict: PASS — no unresolved findings.
Checklist:
- existing root
SKILL.mdbehavior remains one target - direct
.agents/skills/<skill>/SKILL.mdroots are deterministic - each skill has an independent target, source set, and analysis pipeline
- root and nested layouts do not merge execution surfaces
- deeper undocumented nesting is rejected
- directory symlinks are not followed as skill roots
- scan include/exclude filtering remains anchored to the requested scan root
- shared pipeline replaces duplicated parse/analyze/merge logic
- no public API, output, policy, detector, fingerprint, or dependency change
- default/no-default and supported feature configurations pass
limaronaldo
marked this pull request as ready for review
July 24, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/skills/<skill>/SKILL.mdlayouts in addition to a rootSKILL.mdScanTargetper skill root instead of merging unrelated skillsWhy
The initial local implementation combined every discovered skill into one target. That could let cross-file analysis and detector attribution cross skill boundaries. This change preserves the conservative attribution contract by treating each skill directory as an independent extension.
Compatibility
Existing root-level
SKILL.mdprojects still produce one OpenClaw target. No public Rust API, output schema, detector, policy, fingerprint, or dependency changes.Review
Diff-scoped code review found and resolved three issues before publication: cross-skill attribution, overly broad nested discovery, and duplicated pipeline logic. No unresolved findings remain.
Validation
cargo fmt --all --checkcargo check --workspace --all-targets --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-targets --locked— 422 passedcargo test --no-default-features --locked— 388 passedgit diff --check