feat(analysis): add internal risk score model - #69
Merged
Conversation
limaronaldo
commented
Jul 24, 2026
limaronaldo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code review verdict: PASS — no unresolved findings.
Evidence reviewed:
- deterministic BTreeMap ordering and fingerprint deduplication
- highest-contribution conflict resolution independent of input order
- checked sum, multiplication and denominator arithmetic
- score bounds, monotonicity and reserved value 100
- coverage identity order independence and context sensitivity
- source-safe serialized contributions
- policy, suppression, override and CLI-baseline input boundary
- explicit correlated-finding inflation behavior
- public API/output/policy/DSSE non-integration
- default and no-default feature gates
Two medium test-coverage gaps found during local review were fixed before publication: effective-input boundary coverage and correlated/representative fixture evidence.
limaronaldo
marked this pull request as ready for review
July 24, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentshield-risk-v1assessment modelCompatibility
E.1 intentionally has no production caller. It does not change public Rust APIs, findings, policy, verdicts, exit status, fingerprints, baselines, suppressions, renderers or DSSE. The narrow non-test dead-code allowance documents this separate review gate and is removed when E.2 adds an explicit opt-in consumer.
Review findings addressed
Validation
cargo fmt --all --checkcargo check --workspace --all-targets --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-targets --locked— 414 passedcargo test --no-default-features --locked— 380 passedgit diff --check