feat(analysis): add local discovery registry - #66
Merged
Conversation
limaronaldo
force-pushed
the
feature/local-discovery-d0
branch
from
July 24, 2026 02:53
66e23cf to
86c4021
Compare
Collaborator
Author
|
Code review verdict: no blocking findings after fixes. Review covered privacy-safe serialization, deterministic IDs/order, aggregate budgets, unsupported semantics, dependency/public-API drift, unsafe use, and default/no-default feature behavior. One issue found and fixed before this verdict: the 1,024-entry budget was per-source; the envelope now enforces it across the complete invocation with deterministic truncation and a bounded diagnostic. Local gates: fmt, workspace check, all-feature clippy, 381 default tests, and 347 no-default-feature tests pass. Cargo.lock, public API, scan behavior, and existing outputs are unchanged. |
limaronaldo
marked this pull request as ready for review
July 24, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentshield.discovery/v1result modelScope
This is D.0 only. It adds no CLI command, public Rust API, filesystem traversal,
network access, subprocess execution, automatic scan, or changes to existing
scan outputs. The temporary module-level
dead_codeallowance is required bythe accepted split and must be removed in D.1.
The initial registry entries follow current official client documentation for
Cursor global/workspace MCP configuration, Claude Code project
.mcp.json, andVS Code workspace
.vscode/mcp.json.Validation
cargo fmt --all --checkcargo check --workspace --all-targets --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-targets --locked— 381 passedcargo test --workspace --all-targets --no-default-features --locked— 347 passedgit diff --check