Skip to content

Fix Plotly preview crash and streamline README note - #8

Merged
FlorianNachtigall merged 2 commits into
mainfrom
floriannachtigall-add-automatic-pr-preview-deployment-a2b
Oct 5, 2026
Merged

FlorianNachtigall merged 2 commits into
mainfrom
floriannachtigall-add-automatic-pr-preview-deployment-a2b

Conversation

@FlorianNachtigall

@FlorianNachtigall FlorianNachtigall commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • fix the Plotly preview first-load crash by stabilizing the plot element reference used during cleanup
  • guard cleanup/resizing so Plotly cleanup never receives a null/undefined DOM element
  • collapse the README PR preview deployment details into one concise note under Notes

Validation

  • npm run build

Closes #4

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@FlorianNachtigall
FlorianNachtigall force-pushed the floriannachtigall-add-automatic-pr-preview-deployment-a2b branch from 2f95351 to 123fd65 Compare October 5, 2026 19:32
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

💤 This PR is closed. The preview is no longer maintained.

Last preview URL:
https://ai4up.github.io/cities-learning-explorer/pr-8/

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@FlorianNachtigall
FlorianNachtigall force-pushed the floriannachtigall-add-automatic-pr-preview-deployment-a2b branch from 123fd65 to 18f2bcb Compare October 5, 2026 19:52
@FlorianNachtigall
FlorianNachtigall merged commit aae08cb into main Oct 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automatic PR preview deployment

1 participant