Repository navigation
Report PD coordinator paths accurately in notifications - #38
Draft
huangxinV587 wants to merge 1 commit into
Draft
huangxinV587 wants to merge 1 commit into
huangxinV587 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A strict P/D gateway health snapshot reports Coordinator paths, which can share the same model instances. Label those observations and redundancy events as P/D paths so notifications do not imply independent machines. Existing node-oriented notifications keep their current behavior.
Validation:
python -m unittest discover -s tests -v(226 tests, 8 skipped); notification tests cover path outage and recovery messages. Individual P/D node alarms and end-to-end message delivery are not covered by this change.