test(kv-router): remove low-signal tests

[PeaBrane]

Summary

• remove 25 low-signal tests across kv-router indexer, scheduling, sequence, service, protocol, recovery, and wire modules
• eliminate duplicated coverage, tautological Serde/default/helper checks, and vacuous no-op cases while retaining tests for concurrency, recovery, ownership, cleanup, and wire contracts
• make no production-code changes

Validation

• cargo test -p dynamo-kv-router --no-default-features — 585 passed
• cargo test -p dynamo-kv-router --no-default-features --features standalone-indexer,standalone-slot-tracker,standalone-selection — 656 unit and 3 integration tests passed
• git diff --check
• commit hooks passed except pytest-marker-report, which was skipped because the local project extension is stale and lacks DisaggregationMode.Encode across 24 unrelated Python test modules
• an additional metrics-enabled run passed 667/668 tests; the pre-existing services::indexer::metrics::tests::register_and_encode assertion also fails in isolation because uninstantiated metric-vector labels are absent from the encoded output

Summary by CodeRabbit

• Tests
  • Updated and streamlined test coverage around routing, cleanup, replay, scheduling, recovery, and service behavior.
  • Added several new regression-style tests to better verify state consistency and event replay outcomes.
  • Removed a number of older tests that were redundant or no longer needed.

[datadog-official]

⚠️ Warnings

🚦 1 Pipeline job failed

Docs link check | lychee     

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2461b43 | Docs | Give us feedback!}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f2854ced-f7c2-4a7c-8657-1602030022dd

📥 Commits

Reviewing files that changed from the base of the PR and between f8a8591 and 2461b43.

📒 Files selected for processing (14)

• lib/kv-router/src/indexer/branch_sharded.rs
• lib/kv-router/src/indexer/lower_tier.rs
• lib/kv-router/src/indexer/pruning.rs
• lib/kv-router/src/indexer/tests.rs
• lib/kv-router/src/protocols.rs
• lib/kv-router/src/recovery/cursor.rs
• lib/kv-router/src/scheduling/policy.rs
• lib/kv-router/src/scheduling/queue.rs
• lib/kv-router/src/sequences/block_tracker.rs
• lib/kv-router/src/services/indexer/listener.rs
• lib/kv-router/src/services/indexer/server.rs
• lib/kv-router/src/services/shared_cache/server.rs
• lib/kv-router/src/zmq_wire/tests.rs
• lib/kv-router/tests/standalone_indexer_http.rs

💤 Files with no reviewable changes (14)

• lib/kv-router/src/zmq_wire/tests.rs
• lib/kv-router/tests/standalone_indexer_http.rs
• lib/kv-router/src/services/shared_cache/server.rs
• lib/kv-router/src/recovery/cursor.rs
• lib/kv-router/src/scheduling/queue.rs
• lib/kv-router/src/protocols.rs
• lib/kv-router/src/services/indexer/listener.rs
• lib/kv-router/src/sequences/block_tracker.rs
• lib/kv-router/src/scheduling/policy.rs
• lib/kv-router/src/indexer/lower_tier.rs
• lib/kv-router/src/indexer/tests.rs
• lib/kv-router/src/indexer/pruning.rs
• lib/kv-router/src/indexer/branch_sharded.rs
• lib/kv-router/src/services/indexer/server.rs

---

Walkthrough

Removes approximately 20 unit and integration tests across lib/kv-router (indexer, scheduling, sequences, services, protocols, recovery, zmq_wire). In branch_sharded.rs, one test is replaced with four new cleanup/anchor/dump-replay tests. In pruning.rs, one ordering test is replaced with a heap-rebuild-under-churn test.

Changes

kv-router Test Suite Pruning and Replacement

Layer / File(s)	Summary
New tests replacing removed ones lib/kv-router/src/indexer/branch_sharded.rs, lib/kv-router/src/indexer/pruning.rs	cleanup_updates_router_state replaced by four tests covering worker-wide cleanup, anchor removal/re-install, sibling dp_rank regression, and dump/replay score preservation. test_block_entry_ordering replaced by test_worker_expiry_heap_rebuilds_under_churn.
Removed tests across remaining files lib/kv-router/src/indexer/lower_tier.rs, lib/kv-router/src/indexer/tests.rs, lib/kv-router/src/protocols.rs, lib/kv-router/src/recovery/cursor.rs, lib/kv-router/src/scheduling/policy.rs, lib/kv-router/src/scheduling/queue.rs, lib/kv-router/src/sequences/block_tracker.rs, lib/kv-router/src/services/indexer/listener.rs, lib/kv-router/src/services/indexer/server.rs, lib/kv-router/src/services/shared_cache/server.rs, lib/kv-router/src/zmq_wire/tests.rs, lib/kv-router/tests/standalone_indexer_http.rs	Deletes tests for lower-tier root queries, thread-pool backend, long sequence continuations/interleaved workers, overlap scores, KV-cache serialization, cursor state, FCFS/LCFS scheduling policy ordering, no-workers error, block tracker reference counting, indexer listener replay, indexer server HTTP helpers, shared cache store-and-check, zmq normalizer metadata, and HTTP health endpoint. test_overloaded_provider_filters_at_admission updated to multi_thread tokio flavor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description lacks the required Overview, Details, reviewer-start, and Related Issues sections.	Add the template sections (Overview, Details, Where should reviewer start?, Related Issues) and include the required issue linkage or no-issue confirmation.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing low-signal tests in kv-router.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.