fix(multimodal): make nixl imports lazy#11006
Draft
rmccorm4 wants to merge 1 commit into
Draft
Conversation
Apply the lazy NIXL import patch from PR #10737 to release/1.2.1. Defer nixl._api and dynamo.nixl_connect imports until NIXL transfer classes are instantiated, so non-NIXL startup paths do not fail at module import time. Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
temporarily deployed
to
external_collaborator
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/1.2.1.nixl._apianddynamo.nixl_connectimports inembedding_transfer.pyuntil NIXL embedding-transfer classes are constructed.NixlWriteEmbeddingSender.__del__so a failed NIXL constructor does not raise an ignored cleanup exception.Original PR
Validation
uv build --wheelcd lib/bindings/python && uv build --wheelimportlib.util.find_spec("nixl") is None.embedding_transfer.pyloads without importingnixlordynamo.nixl_connect.LocalEmbeddingSender()constructs without NIXL.NixlWriteEmbeddingSender()raises the expected explicitRuntimeErrorwhen NIXL is absent.__del__exception after the failed NIXL constructor.