Skip to content

ci: only run external-contributor check on fork PRs#10997

Open
nv-anants wants to merge 1 commit into
mainfrom
anants/ext-contributor-fork-gate
Open

ci: only run external-contributor check on fork PRs#10997
nv-anants wants to merge 1 commit into
mainfrom
anants/ext-contributor-fork-gate

Conversation

@nv-anants

@nv-anants nv-anants commented Jun 26, 2026

Copy link
Copy Markdown
Member

The ok-to-test job declares an environment, which makes GitHub create a deployment record on every PR and surfaces a "temporarily deployed to external_collaborator" entry in the PR timeline. The job's steps were already no-ops for non-fork PRs, so gate the whole job on github.event.pull_request.head.repo.fork and drop the now-redundant per-step fork checks. Internal PRs no longer trigger the job or the deployment message; fork PRs are unaffected.

Summary by CodeRabbit

  • Bug Fixes
    • Updated automated PR handling so approved external contributors receive the same follow-up checks and comments even when their changes are not from a fork.
    • Improved consistency of commit-signature verification and test-approval messaging for eligible pull requests.

The ok-to-test job declares an environment, which makes GitHub create a
deployment record on every PR and surfaces a "temporarily deployed to
external_collaborator" entry in the PR timeline. The job's steps were
already no-ops for non-fork PRs, so gate the whole job on
github.event.pull_request.head.repo.fork and drop the now-redundant
per-step fork checks. Internal PRs no longer trigger the job or the
deployment message; fork PRs are unaffected.

Signed-off-by: Anant Sharma <anants@nvidia.com>
@nv-anants nv-anants requested a review from a team as a code owner June 26, 2026 18:21
@nv-anants nv-anants temporarily deployed to external_collaborator June 26, 2026 18:21 — with GitHub Actions Inactive
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test actions labels Jun 26, 2026
@datadog-official

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

Docs link check | lychee   View in Datadog   GitHub Actions

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9c297c6 | Docs | Give us feedback!

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 799946fa-0605-428a-bf5d-5fe9e538874c

📥 Commits

Reviewing files that changed from the base of the PR and between 38087d6 and 9c297c6.

📒 Files selected for processing (1)
  • .github/workflows/approved-external-contributor.yml

Walkthrough

The workflow for approved external contributors now gates downstream signature-verification, cleanup, and comment steps only on the PR author approval result. The fork-detection requirement was removed from those conditions.

Changes

Approved external contributor workflow

Layer / File(s) Summary
Approval gate update
.github/workflows/approved-external-contributor.yml
The approval validation step remains, and the verify-commit-signatures condition now depends on approval without requiring fork detection.
Comment and cleanup conditions
.github/workflows/approved-external-contributor.yml
The stale unsigned-commits cleanup, unsigned-commit comment, and /ok to test comment conditions now rely on approval plus the existing signed/unsigned checks, without the fork check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description omits the required Overview, Details, reviewer start, and Related Issues sections from the template. Reformat the PR body to match the template and add the required issue linkage or explicit no-issue confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main workflow change, though it uses broader wording than the specific ok-to-test job update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant