ci: only run external-contributor check on fork PRs#10997
Open
nv-anants wants to merge 1 commit into
Open
Conversation
The ok-to-test job declares an environment, which makes GitHub create a deployment record on every PR and surfaces a "temporarily deployed to external_collaborator" entry in the PR timeline. The job's steps were already no-ops for non-fork PRs, so gate the whole job on github.event.pull_request.head.repo.fork and drop the now-redundant per-step fork checks. Internal PRs no longer trigger the job or the deployment message; fork PRs are unaffected. Signed-off-by: Anant Sharma <anants@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow for approved external contributors now gates downstream signature-verification, cleanup, and comment steps only on the PR author approval result. The fork-detection requirement was removed from those conditions. ChangesApproved external contributor workflow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ok-to-test job declares an environment, which makes GitHub create a deployment record on every PR and surfaces a "temporarily deployed to external_collaborator" entry in the PR timeline. The job's steps were already no-ops for non-fork PRs, so gate the whole job on github.event.pull_request.head.repo.fork and drop the now-redundant per-step fork checks. Internal PRs no longer trigger the job or the deployment message; fork PRs are unaffected.
Summary by CodeRabbit