fix(recipes): bump Hugging Face Hub helper-job pins to 1.16.4#10986
fix(recipes): bump Hugging Face Hub helper-job pins to 1.16.4#10986MatejKosec wants to merge 2 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> (cherry picked from commit 5b090f6)
|
👋 Hi MatejKosec! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (18)
WalkthroughThe PR updates Kubernetes job startup scripts across LoRA sync and recipe model-download workflows to install ChangesHugging Face client pin update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Summary
Updates the Hugging Face Hub CLI pin used by Dynamo model-cache and vLLM LoRA helper jobs from
1.11.0to1.16.4.Issue #10857 reports that the Qwen3-32B model-cache job fails after installing
huggingface_hub==1.11.0because thehfCLI import path is missingclick. The issue reporter confirmed thathuggingface_hub==1.16.4installs the needed CLI dependencies and allows the samehf downloadcommand to run.Scope
This change is limited to helper YAML files that install Hugging Face Hub immediately before an
hf downloadcommand. It preserves the existing package spelling in each file:huggingface_hub==1.11.0→huggingface_hub==1.16.4huggingface-hub==1.11.0→huggingface-hub==1.16.4No model IDs, revisions, cache paths, PVCs, image names, resource requests,
awsclipins, HF token wiring, Dockerfiles, runtime code, operator code, Rust code, or Python code are changed.Files changed
The diff contains 18 one-line YAML replacements under:
recipes/*/model-cache/model-download*.yamlexamples/backends/vllm/deploy/lora/**/sync-lora-job.yamlValidation
The factory run validated the generated branch before publication:
pre-commit run --files <18 changed YAML files> --hook-stage manualpassed.huggingface[_-]hub==1.11.0pins remain in the planned recipe/example scope.hf downloadcommand and that the diff consists only of exact1.11.0→1.16.4pin replacements.huggingface_hub==1.16.4and imported bothclickandhuggingface_hub.cli.hf.mainsuccessfully.A full Kubernetes model-cache job was not run because it would require cluster/PVC/HF-token setup and large model downloads. This PR addresses the CLI dependency pin that caused the import failure.
Summary by CodeRabbit