Skip to content

docs(agents): add missing AGENTS symlinks#10984

Open
carlory wants to merge 1 commit into
ai-dynamo:mainfrom
carlory:codex/add-agents-symlinks
Open

docs(agents): add missing AGENTS symlinks#10984
carlory wants to merge 1 commit into
ai-dynamo:mainfrom
carlory:codex/add-agents-symlinks

Conversation

@carlory

@carlory carlory commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add AGENTS.md symlinks alongside existing CLAUDE.md files in packages that were missing agent instructions aliases.
  • Keep the symlinks consistent with existing directories that already use AGENTS.md -> CLAUDE.md.

Validation

  • find . -name CLAUDE.md -exec sh -c 'for f do d=${f%/*}; test "$d" = "$f" && d=.; test -e "$d/AGENTS.md" || echo "$d"; done' sh {} +
  • uv tool run pre-commit run --all-files --show-diff-on-failure
  • git commit -s -m "docs(agents): add missing AGENTS symlinks" pre-commit and commit-msg hooks passed

Summary by CodeRabbit

  • Chores
    • Updated several guidance files to point to a shared reference file.
    • Standardized agent instruction locations across backend, router, KV, LLM, mocker, and test areas.
    • No functional, API, or runtime behavior changed.

Signed-off-by: carlory <baofa.fan@daocloud.io>
@copy-pr-bot

copy-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@carlory carlory temporarily deployed to external_collaborator June 26, 2026 07:57 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi carlory! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor docs documentation Improvements or additions to documentation router Relates to routing, KV-aware routing, etc. labels Jun 26, 2026
@carlory carlory marked this pull request as ready for review June 26, 2026 08:01
@carlory carlory requested a review from PeaBrane as a code owner June 26, 2026 08:01

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: db43a449-76a4-4a91-8331-f2506d5a5ff3

📥 Commits

Reviewing files that changed from the base of the PR and between 15bdb11 and 2fab673.

📒 Files selected for processing (18)
  • components/src/dynamo/common/backend/AGENTS.md
  • components/src/dynamo/router/AGENTS.md
  • lib/backend-common/AGENTS.md
  • lib/kv-router/AGENTS.md
  • lib/kv-router/src/indexer/concurrent_radix_tree_compressed/AGENTS.md
  • lib/kv-router/src/scheduling/AGENTS.md
  • lib/kv-router/src/sequences/AGENTS.md
  • lib/kv-router/src/services/AGENTS.md
  • lib/kv-router/src/services/indexer/AGENTS.md
  • lib/kv-router/src/services/slot_tracker/AGENTS.md
  • lib/kvbm-engine/AGENTS.md
  • lib/kvbm-kernels/AGENTS.md
  • lib/kvbm-logical/AGENTS.md
  • lib/llm/src/local_model/AGENTS.md
  • lib/llm/src/request_trace/AGENTS.md
  • lib/mocker/src/scheduler/vllm/AGENTS.md
  • tests/AGENTS.md
  • tests/router/AGENTS.md

Walkthrough

Multiple AGENTS.md files under components, lib, and tests were updated to reference CLAUDE.md as their target. No runtime code or exported APIs changed.

Changes

AGENTS.md symlink target updates

Layer / File(s) Summary
CLAUDE.md link targets
components/src/dynamo/.../AGENTS.md, lib/backend-common/AGENTS.md, lib/kv-router/.../AGENTS.md, lib/kvbm-.../AGENTS.md, lib/llm/src/.../AGENTS.md, lib/mocker/src/scheduler/vllm/AGENTS.md, tests/.../AGENTS.md
These AGENTS.md files now point to CLAUDE.md instead of storing independent content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes summary and validation, but it omits required template sections like Overview, Details, reviewer start, and Related Issues. Add the missing template sections, especially Overview, Details, Where should reviewer start?, and the required Related Issues entry.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change: adding missing AGENTS symlinks to CLAUDE.md files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation external-contribution Pull request is from an external contributor router Relates to routing, KV-aware routing, etc. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant