Repository navigation
fix(framework): leave model selection to the user - #989
Merged
Merged
Conversation
blafourcade
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Bundled skills and agents override the user’s model with Sonnet or Opus. Remove those presets so execution uses the host’s model configuration.
🛠️ How it works
Remove model fields from five dev skills, both dev agents and the agent scaffold. Agent generation accepts a model only when the user requests one. Remove the marketplace tier table. General guidance on selecting lightweight agents and the token-optimization recipe stay unchanged. The evaluation harness passes
--modelonly when explicitly supplied.Telemetry records, provider schemas and compatibility fixtures retain model identifiers because they describe data or supported formats.
🧪 How to verify
node --test scripts/__tests__/model-selection.test.js: 3 passing tests; two reproduced the forced defaults before removal. The harness tests use a stub CLI and spend no tokens.pnpm exec lefthook run pre-commit: 557 passing tests; documentation checks pass.node scripts/check-architecture-rules.js: 352 governed files, zero violations.✅ I certify