Repository navigation
Conversation
Contributor
|
@tkman59 this branch now conflicts with #958 should also fix #890 (the memory hook wired into |
tkman59
force-pushed
the
feat/511-antigravity-host
branch
2 times, most recently
from
October 13, 2026 21:22
5c423e9 to
058b4ef
Compare
blafourcade
requested changes
Oct 14, 2026
blafourcade
left a comment
Contributor
There was a problem hiding this comment.
Reviewed line by line and ran the stack tip (agy 1.3.5, pnpm test, build, real aidd setup --ai antigravity).
Blocking
cli/src/contexts/tools/domain/profiles/antigravity/profile.ts: the skip message shown to users containsfollow-up phase 3 of #511, andprofile.unit.test.tsasserts.toContain("phase 3"). This breaks.claude/rules/01-standards/2-tracker-ids.md(no ticket IDs in code or tests). #958 removes it, but this PR must not merge with it. Suggestion: "Antigravity CLI hooks are not wired yet." and adapt the assertion.
Minor
registry-conformance.unit.test.ts: the new earlyreturnfor a tool with neitherbuildContracts.marketplacenordistributionProbesweakens the guard for any future flat-only tool. An explicit opt-out would be safer.
Checked and fine
- Every other tool's output is unchanged (they all declare a commands capability), and
flatSkillLayoutdefaults tonestedeverywhere except Antigravity. - A real setup writes skills one level deep only. No
if (tool === "antigravity")in shared code. - Typecheck, lint, knip, architecture tests and the full suite pass.
Teams moved from Gemini CLI to Antigravity CLI (agy) have no AIDD install. This adds an isolated `antigravity` flat profile that writes AIDD skills under `.agents/skills/`, from setup and from `translate --to antigravity --as flat`. agy 1.2.14 discovers a skill only directly under `.agents/skills/`: a probe at `.agents/skills/<plugin>/<skill>/SKILL.md` logs no expansion, one at `.agents/skills/<skill>/SKILL.md` logs `expanded slash command`. A flat profile can therefore declare a `single-level` skill layout, `skills/<plugin>-<skill>/`, which the flat install now recognises; every other tool keeps the `nested` default. Hooks and agents stay unsupported until their own phases. The golden snapshot gains only the `antigravity:flat` cell. Refs #511 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The setup smoke asserts a `.<tool>/` directory per AI tool, but Antigravity writes under the shared `.agents/` root, so `pnpm smoke` failed with "antigravity dir missing after --ai all". Refs #511 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tkman59
force-pushed
the
feat/511-antigravity-host
branch
from
October 14, 2026 20:52
058b4ef to
7a4f6bc
Compare
Author
|
Thanks, addressed in the host commit (stack replayed).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Teams moved from Gemini CLI to Antigravity CLI (
agy) get no AIDD install. This adds an isolatedantigravityflat profile that writes AIDD skills under.agents/skills/, fromaidd setup --ai antigravityand fromaidd translate --to antigravity --as flat. First of four PRs for #511: skills only; the memory hook, agents and docs follow.🛠️ How it works
supported: falsewith a reason, hooks refused until the next phase.agy1.2.14 (2026-10-05): a probe at.agents/skills/flat-probe/SKILL.mdlogsexpanded slash command "flat-probe" (skill); one at.agents/skills/aidd-probe/nested-probe/SKILL.mdlogs no expansion. So Antigravity can't use theskills/<plugin>/<skill>/tree Kilo and OpenCode get.nested(default, unchanged for every existing tool) orsingle-level,skills/<plugin>-<skill>/(plugins-capability.ts:136, set at antigravity/profile.ts:45). The flat install reads it when writing (content-translator.ts:353) and when matching a built file back to its plugin (built-tree-materialization-translator.ts:185). Before that, setup installed 0 skills from the one-level tree..agents/commands/for Antigravity. No other tool's output changes.tool-addition-cost.archdemands, atools-antigravitymutation scope (82.5), and a{ tool: antigravity, mode: flat }row in thebuild-per-toolmatrix.🧪 How to verify
cd cli && pnpm test: 6818 passed.golden.jsongains only theantigravity:flatcell; no existing cell changes.aidd setup --source local --path <framework> --ai antigravity --plugins all --yeswrites 51.agents/skills/*/SKILL.md, all one level deep. Then, logged in toagy:agy -p "/aidd-context-11-explore" --add-dir .logsexpanded slash command "aidd-context-11-explore" (skill)in~/.gemini/antigravity-cli/log/cli-*.log. Read the log, not the turn: print mode hangs after answering.tests/e2e/clean-antigravity-foreign-file.e2e.test.ts: a user file under.agents/skills/survivesaidd clean.agyturn needs a Google login. CI covers the golden cell and the matrix build only..agents/skills/; uninstalling one deletes plugin files the other still records.single-levelskill belongs to a plugin by its<plugin>-prefix, so a future plugin namedaidd-dev-xwould matchaidd-dev. Flat agents already work this way.scripts-testswas excluded for this commit.check-written-file-hook.test.jswrites and deletes a file incli/srcwhilecomments-name-files-that-exist.test.jsreads that directory in parallel (ENOENT .hook-probe-<pid>-broken.ts). This happens locally only, and the same suite passes run serially (549/549). CI skips the writer because Biome isn't installed there.🔗 Linked issue
Refs #511
✅ I certify
🤖 Generated with Claude Code