Repository navigation
fix(cli): canonicalize architecture comparison paths on Windows - #880
Merged
blafourcade merged 1 commit intoSep 20, 2026
Merged
blafourcade merged 1 commit into
blafourcade merged 1 commit into
Conversation
This was referenced Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Native Windows path separators make the architecture rules select no source files or miss import edges. This normalizes the comparison keys while leaving filesystem operations native.
How it works
helpers.ts canonicalizes
sourceFiles,pluginReadmes, and relative import targets together. The separate test/port producers and diagnostic paths use the same conversion. Zero-selection assertions and debt baselines remain intact.Eight ordinary Vitest cases cover explicit backslash inputs on any platform, nonempty source/plugin scopes, and an actual relative-import lookup.
How to verify
From
cli/, runpnpm exec vitest run --project=architecture tests/architecture/paths-select-source.arch.test.tsandpnpm test:arch.Native Windows, Node 22.23.1:
83b0246e: 79 passed, 21 failed, 2 collection errors. Candidate: 117 passed, 5 failed, 1 collection error, with no newly failing assertions.Heads-up
The full architecture suite is not green: three Biome launcher checks, the workflow parser, the codebase-map fenced-block check, and
mutation-covers-sourcestill fail. Those files are unchanged.docs-do-not-lienow collects through the corrected shared command-path lookup.The candidate was rerun with declared pnpm 12.3.4; dependencies were originally installed with 11.19.0 and
--ignore-scripts, not freshly installed with 12.3.4. Linux was not run locally; explicit backslash tests are in the normal Vitest architecture project. The Biome launcher defect is tracked separately as requested.Linked issue
Closes #863.
I certify