[nightcityblade]

🎯 What & why

Upgrade generated async-development workflows from actions/checkout@v4 to @v5 before Node 20 runner compatibility is removed.

🛠️ How it works

Updates all three production template steps plus the mirrored real-framework fixture, then refreshes the fixture hash snapshot.

🧪 How to verify

• Confirm the production template contains three actions/checkout@v5 references and no @v4 references.
• Confirm the fixture SHA-256 matches all nine golden snapshot entries.
• git diff --check

Full pnpm tests could not run because the host pnpm 12.3.4 shim is broken (ENOEXEC); deterministic template/hash checks passed.

🔗 Linked issue

Closes #729

Worked on by

• nightcityblade

✅ I certify

• I DO CERTIFY I READ EACH LINE OF THE PULL REQUEST BECAUSE I AM A SOFTWARE ENGINEER, NOT A AI PUPPY.

[blafourcade]

Thanks for picking this up, and for the honesty about what you could not run. The substance is right: the three actions/checkout@v4 → @v5 steps in plugins/aidd-orchestrator/skills/00-async-dev/assets/setup/workflow-template.yml are exactly what #729 asked for, and those three lines can stay as they are.

Two things to change before this can merge.

1. The base branch must be next, not main.

main is the production branch; only hotfix/* targets it. Everything else batches on next and ships in the weekly release — the table in aidd_docs/memory/vcs.md maps branch prefix to target, and fix/* goes to next. This is also why the PR currently shows as blocked: the branch policy on main refuses it.

gh pr edit 878 --base next

Nothing to rebase — your commit applies cleanly either way.

2. Drop the framework-real fixture changes.

Two of your three files should not be in this diff:

• cli/tests/fixtures/framework-real/plugins/aidd-async-dev/skills/01-setup/assets/workflow-template.yml
• cli/tests/golden/snapshots/framework-build/golden.json

framework-real is not a copy of the current framework. It is a pinned snapshot of tag v4.1.0-beta.12, kept deliberately frozen so the translation and golden tests have a deterministic, realistic historical source. Its own README says so, and it is refreshed only by scripts/refresh-framework-fixture.sh <tag>, never by hand:

Pinned snapshot of aidd-framework tag v4.1.0-beta.12.

The giveaway is the path itself: plugins/aidd-async-dev/ is a plugin that no longer exists — this work lives in aidd-orchestrator now. Editing the snapshot makes it a worse historical record, and the nine golden.json hash updates are only needed because of that edit. #865 was closed for the same reason last week.

So the PR should be one file and six lines:

git checkout origin/next -- cli/tests/fixtures/framework-real cli/tests/golden/snapshots/framework-build/golden.json

On the tests. Once the two points above are done, CI runs the full suite for you, so a broken local pnpm is not a blocker for this PR. For future work: this repository pins pnpm through packageManager, and corepack enable && corepack prepare --activate usually fixes an ENOEXEC shim. If it persists, say so and I will look at it — a contributor who cannot run the suite locally is a problem worth fixing on our side.

Re-request a review once pushed.

---

Generated by Claude Code