Repository navigation
feat(refine): remove condense skill and its hook - #624
Merged
Merged
Conversation
The condense skill duplicated a concern that belongs to the host tool's own output settings, and its `UserPromptSubmit` hook parsed a marker line the model emitted only inconsistently (see the eval harness's own "known findings" note). Rather than harden a best-effort mechanism, drop it. Removing `03-condense` frees the slot, so the two skills after it move up to keep the plugin's numbering contiguous. BREAKING CHANGE: `aidd-refine:03-condense` is removed, and the skills after it are renumbered: `04-shadow-areas` becomes `03-shadow-areas`, and `05-fact-check` becomes `04-fact-check`. Any pinned reference to the old names must be updated. The plugin no longer ships a hooks directory. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blafourcade
force-pushed
the
feat/refine-remove-condense
branch
from
August 13, 2026 05:18
d6d7cfc to
be14ae9
Compare
blafourcade
marked this pull request as ready for review
August 13, 2026 05:19
aidd-bot Bot
pushed a commit
that referenced
this pull request
Aug 14, 2026
The condense skill duplicated a concern that belongs to the host tool's own output settings, and its `UserPromptSubmit` hook parsed a marker line the model emitted only inconsistently (see the eval harness's own "known findings" note). Rather than harden a best-effort mechanism, drop it. Removing `03-condense` frees the slot, so the two skills after it move up to keep the plugin's numbering contiguous. BREAKING CHANGE: `aidd-refine:03-condense` is removed, and the skills after it are renumbered: `04-shadow-areas` becomes `03-shadow-areas`, and `05-fact-check` becomes `04-fact-check`. Any pinned reference to the old names must be updated. The plugin no longer ships a hooks directory. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
blafourcade
added a commit
that referenced
this pull request
Aug 14, 2026
The condense skill duplicated a concern that belongs to the host tool's own output settings, and its `UserPromptSubmit` hook parsed a marker line the model emitted only inconsistently (see the eval harness's own "known findings" note). Rather than harden a best-effort mechanism, drop it. Removing `03-condense` frees the slot, so the two skills after it move up to keep the plugin's numbering contiguous. BREAKING CHANGE: `aidd-refine:03-condense` is removed, and the skills after it are renumbered: `04-shadow-areas` becomes `03-shadow-areas`, and `05-fact-check` becomes `04-fact-check`. Any pinned reference to the old names must be updated. The plugin no longer ships a hooks directory. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Merged
blafourcade
added a commit
that referenced
this pull request
Aug 14, 2026
The root package's path is the whole repository, so the BREAKING CHANGE footer on #624 counted against the umbrella as well as against aidd-refine, and the marketplace jumped 5.7.1 -> 6.0.0. Path filtering cannot fix this: that commit also edits README.md, docs/ and scripts/, so the breaking footer reaches the root whatever is excluded. Roll the umbrella back to 5.7.1 in the manifest, in marketplace.json and in the root changelog, leaving every component entry untouched so their published tags stay authoritative and nothing is re-released. Pin the next root release to 5.8.0, the version this cycle should have produced. aidd-refine 3.0.0 is correct and stays: the breaking change is real, it just belongs to the plugin rather than to the marketplace. The pin must be removed once v5.8.0 is published. Co-authored-by: aidd-bot[bot] <aidd-bot[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Removes
aidd-refine:03-condenseand theUserPromptSubmithook that backed it. The skill overlapped with the host tool's own output settings, and its02-statsaction depended on the model emitting a literalCondense: ON (<level>).marker that it paraphrased in practice — a limitation the eval harness already documented as a known finding rather than a bug worth fixing.🛠️ How it works
Three moves, in order:
skills/03-condense/andhooks/.hooks.jsonregistered only the condense hook, so the whole directory goes rather than leaving an empty manifest behind.aidd-contextis now the only plugin shipping hooks — docs/ARCHITECTURE.md drops to a single row.git mvso rename detection survives review:04-shadow-areas→03-shadow-areas,05-fact-check→04-fact-check. BothSKILL.mdfrontmattername:fields follow.aidd-refine:01-brainstormandaidd-refine:02-challengereferenced from other plugins (checker.md:46, 03-check.md:26, the cook recipes,idle-menu.md), and neither moves. So the renumber is safe for every other plugin.Two details worth a reviewer's eye:
plugin.jsonandmarketplace.jsoncarried a byte-identical description string mentioning "condensed communication mode". Both are rewritten to the same new string so they can't drift.hooks/condense-stats.jsas its worked example of a file that exists. Deleting the hook would have inverted the test, so the example now points atplugins/aidd-context/hooks/update_memory.js.CATALOG.mdand the README counts are auto-generated; both were regenerated with the exact invocations from lefthook.yml rather than hand-edited.Deliberately untouched:
cli/tests/fixtures/framework-real/is a pinnedv4.1.0-beta.12snapshot with its own refresh script, and framework-build-golden.e2e.test.ts:34 builds from that fixture rather than the live tree — so thecondensestrings still ingolden.jsonare correct and must stay. CHANGELOGs are history.🧪 How to verify
Run the real pre-commit gates:
All four pass on this branch (
✅ Links: 0 broken in 673 files; README settles at4 skillsforaidd-refine, 47 total).Confirm nothing stale is left behind:
Returns nothing.
aidd-refine:04-shadow-areasoraidd-refine:05-fact-checkby name must update to the new numbers. The commit carriesBREAKING CHANGE:so release-please bumpsaidd-refineaccordingly;.release-please-manifest.jsonis left at2.2.4for the tooling to own.03-condenseeval case is removed fromscripts/skill-eval/cases.json, and its entry under "Known findings" in the harness README goes with it.