Repository navigation
fix: name lifecycle hooks in Codex - #1156
Merged
Merged
Conversation
alexsoyes
marked this pull request as ready for review
November 5, 2026 09:57
blafourcade
reviewed
Nov 5, 2026
Contributor
Author
|
@blafourcade j'adresse tes changements et on peut merge je pense, de toute façon on va devoir refaire le hook ne serait-ce que pour formater les descriptions :) |
alexsoyes
enabled auto-merge (squash)
November 5, 2026 23:51
Contributor
Author
Revue OpenCodeCommit examiné : Lot 1Verdict: approve. No actionable defects found in the supplied changes. The hook definitions name each existing handler, and the generator instructions require and validate names for new Claude Code and Codex handlers. Runtime behavior was not independently verified; the PR snapshot reports isolated-session testing, with Cursor native runtime unverified. Verdict de ce lot : approve |
blafourcade
approved these changes
Nov 7, 2026
blafourcade
force-pushed
the
codex/name-lifecycle-hooks
branch
from
November 7, 2026 05:19
23ed081 to
455991e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Codex displays AIDD hooks as “Unnamed hook”, making review and trust decisions difficult. Name the existing handlers and teach the hook generator to name future Claude and Codex handlers.
🛠️ How it works
statusMessageidentifies each handler in Codex's hook review. The generator requires and validates a descriptive message for Claude and Codex without adding unsupported fields to other tool formats.🧪 How to verify
08-hook-generate: both includestatusMessageand existing hooks remain intact. Exercised in an isolated Codex session.node --test scripts/__tests__/aidd-telemetry-hooks.test.js scripts/__tests__/aidd-ui-validate.test.js: 120 tests passed.Changing a hook definition requires reviewing its trust again. The maintenance plugin is not yet on
next; its hook is updated separately in #1145.✅ I certify