Repository navigation
Conversation
Test manuel de la revue OpenCodeTest lancé localement avec OpenCode 2.2.5, le provider OpenAI, Note : la mention « non commitées » vient de Revue : Prototype OpenCode reviews after submissionRound 1
Critères
Hypothèses
Constat
Limites
Fichiers examinés
Verdict : changes-requested |
alexsoyes
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Test du déclenchement automatique de la revue OpenCode.
Revue OpenCode — 1/1Commit examiné : Lot 1/1Verdict: changes requested
Runtime verification was not performed; the supplied context says the timer-to-comment path remains untested. Verdict des segments de ce commentaire : changes-requested |
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Test de non-répétition après une nouvelle soumission, sans changement.
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Test du correctif des modes Git et de la revue incrémentale.
Revue OpenCode — 1/1Commit examiné : Lot 1/1Verdict: changes requested
Runtime behavior was not independently verified; this was a read-only review. Verdict des segments de ce commentaire : changes-requested |
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Test de la revue automatique par fichier et de la reprise incrémentale.
Revue OpenCode — 1/1Commit examiné : Lot 1/1Verdict: approve. No actionable defects found in the supplied files. The review was limited to the supplied diffs and PR context; runtime checks were not run. Verdict des fichiers de ce commentaire : approve |
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Test de la revue OpenCode simplifiée et des fichiers déjà examinés.
Revue OpenCodeCommit examiné : Lot 1Verdict: changes requested
Limit: This was a read-only review; runtime behavior was not independently verified. Verdict de ce lot : changes-requested |
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
Vérification finale de la revue simplifiée après limitation du contexte.
Revue OpenCodeCommit examiné : Lot 1Verdict: approveNo actionable defects found in the supplied files. Limit: This was a read-only review; tests were not run. Verdict de ce lot : approve |
OpenCode reviewReviewed commit: Review: changes needed
Limits: Static review only; repository code and checks were not executed. No plan or acceptance criteria were supplied, so the functional axis was not applied. Fully examined targets:
Targeted files not fully reviewed: None. |
|
OpenCode smoke test passed. No file changed. · run |
alexsoyes
left a comment
alexsoyes
left a comment
There was a problem hiding this comment.
acknowledge all of it, plan a new refactoring.
| REVIEW_MODEL_RUNNER: /opt/aidd/run-review | ||
| AIDD_REVIEW_ENABLED_AT: ${{ vars.AIDD_REVIEW_ENABLED_AT }} | ||
| run: | | ||
| set -euo pipefail |
There was a problem hiding this comment.
call a outside script please
| name: Run OpenCode | ||
| # 8973343 is @alexsoyes (Alex), the repository owner. | ||
| if: github.event.comment.user.id == 8973343 && startsWith(github.event.comment.body, '/opencode') | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
Why? Really necessary? Slim is preferable
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| set -euo pipefail |
There was a problem hiding this comment.
outside script please
| { | ||
| "$schema": "https://opencode.ai/config.json", | ||
| "skills": [ | ||
| "/trusted/.claude/skills", |
There was a problem hiding this comment.
why do I need this? to use the framework installed on the project?
remember we want to use the framework only if installed from the project (please read .aidd/*.json)
if so we can install it using npx with the version number and all loaded plugins, sounds fair? simplicity always wins i am ok reinstallating like this.
| "skills": [ | ||
| "/trusted/.claude/skills", | ||
| "/trusted/.agents/skills", | ||
| "/trusted/.opencode/skills" |
There was a problem hiding this comment.
And since the whole PR is about opencode i would focus on it
| @@ -0,0 +1,35 @@ | |||
| # AIDD OpenCode image | |||
|
|
|||
| Build the image from this directory: | |||
There was a problem hiding this comment.
do not duplication info
| @@ -0,0 +1,7 @@ | |||
| Launch the `aidd-orchestrator-reviewer` subagent with this task: | |||
There was a problem hiding this comment.
never name agent, launch a "reviewer" agent is enough.
Review the supplied code and Answer in the PR directly?
Simplicity wins
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| # Run only under the dedicated reviewer UID, with the checkout mounted read-only. |
There was a problem hiding this comment.
WTF is that?
Top comments on EVERY sh scripts please to explain it.
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| root=$(cd "$(dirname "$0")/../.." && pwd -P) |
| @@ -0,0 +1,94 @@ | |||
| #!/usr/bin/env bash | |||
| set -euo pipefail | |||
| root=$(cd "$(dirname "$0")/../.." && pwd -P) | |||
There was a problem hiding this comment.
omg stop testing those this does not NEED to be commited once we prooved the success locally
Revue OpenCodeCommit examiné : La revue est partielle ; les fichiers restants seront réessayés. Lot 1Review: OpenCode PR reviewsVerdict: approve. No actionable defects were identified in the supplied changes. The review was read-only; runtime behavior and the documented production cutover were not independently verified. Verdict de ce lot : approve |
Revue OpenCodeCommit examiné : Lot 1Verdict: approve — no actionable defects found in The supplied test file was reviewed in full against the PR context. The tests were not run. Verdict de ce lot : approve |
Keep reviews grounded in project context while isolating publication credentials.
🎯 What & why
Review a PR when Alex submits a review. Reuse checkpoints for unchanged files while answering new feedback, including when the commit has not changed.
🛠️ How it works
npxinstalls the project's recorded AIDD CLI version and available plugins in an isolated directory. If the manifest is absent, it useslatestand reports that the plugin inventory is unavailable. Other plugin sources and version differences are reported./opencodereceives PR reviews, inline comments and the general discussion. It replies in the original thread when applicable.🧪 How to verify
make checkbash scripts/__tests__/pr-review/test-review.shandbash scripts/__tests__/pr-review/test-setup-project.shbash scripts/__tests__/pr-review/test-runner.sh.npxsetup runs with CLI 5.1.4 and 5.6.0 installed the requested skills directly. The final image smoke passed; its remote setup could not be repeated after the anonymous GitHub API quota was exhausted.main, the dedicated runner group exists andAIDD_REVIEW_ENABLED_ATis set. Stop the existing server timer during cutover to avoid duplicate reviews.✅ I certify