Repository navigation
fix(cli): clear remaining dependency security advisories - #1013
Merged
Merged
Conversation
Validate the qs and esbuild parent-range exceptions without migrating their consumers. Account for the patched compiler emitting TypeScript fields correctly in the measured bundle budget. Refs #469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
Clear the four remaining CLI dependency advisory IDs after #1011. Both full and production audits now report zero findings.
🛠️ How it works
Raise the existing fast-uri and qs floors to
~3.1.8and~6.16.0, and add esbuild~0.28.2in pnpm-workspace.yaml:16. pnpm regenerates only these packages, esbuild's platform binaries and qs's side-channel dependency.Keep Stryker/typed-rest-client and tsup at their existing versions. qs exceeds typed-rest-client's exact pin; esbuild exceeds tsup's declared range. The parent APIs were checked, and real HTTP serialization, CSS/PostCSS, style injection and configuration watch probes pass on the installed graph. These exceptions and upstream sources are recorded in validation.md:1.
Patched esbuild correctly emits TypeScript parameter-property fields that the old compiler omitted, increasing the bundle by 5,008 bytes. Align the measured budget from 751 to 756 KB in the existing registry; application code and minification stay unchanged.
🧪 How to verify
pnpm audit --jsonandpnpm audit --prod --json: zero findings.pnpm test:coverage: 7,025 passed, one skipped; unchanged coverage thresholds pass.45a5a48f4a8bf40da002cff7abcda71803bff248.The dependency overrides intentionally exceed two parent constraints; compatibility is established for this tested graph, not claimed as upstream support. The bundle budget change reflects the measured compiler correctness fix, with approximately 0.05% headroom. All other thresholds and the Vitest runner patch are unchanged.
🔗 Linked issue
Refs #469. Follows #1011; the discovery report remains in #1010.
✅ I certify