Repository navigation
fix(aidd-orchestrator): hardcodes aidd-dev, violates cross-plugin orthogonality #406
Description
Rule
Cross-plugin orthogonality: plugins never reference each other by name — orchestrators included. A skill discovers a cross-plugin capability at runtime by description matching, never a hardcoded aidd-<plugin>:… address. It is not yet mechanically enforced, so violations slip through.
Violation
aidd-orchestrator/skills/00-async-dev hardcodes aidd-dev:
Should delegate by capability:
SKILL.md:29+references/routing.md:36-37— trigger regexes match/aidd-dev:02-implement,/aidd-dev:05-review.SKILL.md:81—check-sdlcverifiesaidd-dev:00-sdlc(should be "an SDLC-capable orchestrator").README.md:17— pointer "useaidd-dev:00-sdlc".
Deployment-level (names the package to install it — harder to make capability-based):
SKILL.md:62,actions/setup/07-install-user-scope-plugins.md,assets/setup/workflow-template.yml:165,260— setup installsaidd-dev@aidd-framework.
Fix options
- Capability-based for triggers +
check-sdlc+ README; leave setup/install naming the package. - Full: make setup capability-driven too (needs design).
- Add a lefthook grep for cross-plugin literals so this can't regress.
Found during the docs rework while verifying ARCHITECTURE.md against the code.
Acceptance criteria
- No file under
plugins/aidd-orchestrator/names another plugin by address. - The skill discovers an SDLC-capable orchestrator by capability, not by the string
aidd-dev. - Uninstalling
aidd-devdegrades the flow with a clear message instead of failing on a missing address. - The check from ci(framework): mechanically enforce cross-plugin orthogonality on PRs #250 passes on this plugin.
Related
- feat(aidd-orchestrator): route by discovered capability, not hardcoded plugin #146 — the feature whose absence causes this: with no runtime capability discovery, there is nothing to route by except a hardcoded address.
- ci(framework): mechanically enforce cross-plugin orthogonality on PRs #250 — the CI check that stops the next violation.
- refactor(aidd-orchestrator): make the delivery loop a contract-compliant router #420 — slims this same skill; its router holds the offending regexes. Land them together.
Activity
blafourcade commentedon Jul 10, 2026
Two issues sit around this one:
[-]aidd-orchestrator violates cross-plugin orthogonality (hardcodes aidd-dev)[/-][+]fix(aidd-orchestrator): hardcodes aidd-dev, violates cross-plugin orthogonality[/+]blafourcade commentedon Jul 10, 2026
Related: #420 slims this same skill. Its router (131 lines) holds the routing regexes that hardcode
aidd-dev. Fixing the address and shrinking the router touch the same lines — pair them.blafourcade commentedon Sep 9, 2026
Resolution
The original violation is no longer the current contract.
00-async-devnow discovers an active SDLC capability from the runtime skill catalog by description, passes the discovered name to delegation, and degrades explicitly when no matching capability is loaded. The same discovery rule is used for review-fix delegation.The broad acceptance criterion “no file under
aidd-orchestrator/names another plugin” is not valid under the current architecture:aidd-devstrings in async-dev comment routing are compatibility input aliases, not a fixed delegation target.The actual dispatch is capability-based. Keep compatibility aliases only as long as the supported trigger contract requires them; their removal is a separate compatibility decision.
The remaining work stays with its owners:
Closing this issue as completed.