Repository navigation
Reject missing device-binding verification units - #80
Open
gspark-etri wants to merge 2 commits into
Open
gspark-etri wants to merge 2 commits into
gspark-etri wants to merge 2 commits into
Conversation
gspark-etri
marked this pull request as ready for review
October 30, 2026 12:21
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding conformance kit previously accepted
ok: truewithunits: []even when an apply plan required writes. It now requires every planned artifact interval exactly once, validates operation/mode/manifest, interval types and bounds, byte digests, and optional nonnegative integer bytes_written. Device byte counts remain independent of artifact interval lengths. Reload apply and rollback derive whole-file intervals from target and base independently, including empty files; identical unit plans may legitimately return an explicit empty list.Twelve stdlib regressions include an end-to-end corrupted fake response that passed before this fix. Review caught empty-file and byte-accounting regressions; both were reproduced, fixed and independently re-reviewed. Root local12tests pass; fake B1 and B2 each pass all4 goldens. Exact-head39696e7 CI41054143706 read green: gofmt/vet/race,12 regressions, fakeB1/B2, CLI build, both SeaweedFS/VersityGW backend conformance and CLI round trips. Python3.6 grammar checked. No storage/schema/vendor code changes.
Stacked on PR #76 at2d84ac3. PR76's author branch remains unchanged; after #76 lands, retarget this PR to main. Addresses the coverage portion of #79. Runtime-valid fixture support and real RNGD owner/readback/retained-rollback remain follow-up work. A passing fake kit is not native B2 conformance.