Repository navigation
CSI: never replace a live socket; remove only our own socket on exit (#61) - #63
Merged
Merged
Conversation
…61) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the #54/#55 cluster run, a plugin pod that stayed Terminating for 28 minutes started late and exited at once. On exit it removed the live plugin's
csi.sock, and every mount failed until the plugin restarted (#61). Two things removed the socket:onggi csiremoved the path on shutdown, and Go'sUnixListeneralso unlinks its path onCloseby default.Changes
csi.Listen:Closeremoves the path only if it is still the socket this process created (same file), once.cmd/onggi/csi.gocloses the listener instead of removing the path.Verification
TestListenKeepsTheLiveSocket:Listenon a live socket fails;Closeleaves the new socket in place;Closeremoves its own socket.TestServeOverUnixSocketand the full suite pass on the node; gofmt and vet are clean.Compatibility and limits
Related Issue
Closes #61
🤖 Generated with Claude Code