Repository navigation
Delta apply: read bytes the base holds at other offsets from its files (prefill after decode: store reads 9.47 → 1.93 GB) (#58) - #60
Merged
Conversation
…es (#58) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Delta apply (#41) only keeps bytes that sit at the same offset in the base. When a variant holds the same bytes at other offsets, the pull fetched them although the node had them (#58):
Changes
chooseBasealso scores each offered base by the bytes it holds anywhere:moved, through a by-digest index of its extents.MinSameof the bytes stay at the same offsets.MinSame,fromBasereads every still-needed stored chunk the base holds from the base's files where they are:local_base,local_bytes.onggi pull --basereports which path was used. The CSI plugin's offer gets the local path as well.Verification
--baseB2 (0 % same offset, 79 % elsewhere)The store here is on the same disk, so the time gain is small. Against a network store, the 80 % fewer store reads are the gain.
Compatibility and limits
Related Issue
Closes #58
🤖 Generated with Claude Code