Repository navigation
Delta apply: log why nothing was taken over; cluster results (#49) - #50
Merged
Merged
Conversation
#49) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In the #41 cluster check, a prefill pod did not take over the idle decode artifact. That was expected, but the log could not show why (#49).
Changes
PullStats.BaseBest: the bytes the best offered base keeps at the same offsets, whether it was taken or not.chooseBasenow returns its best candidate together with the decision.no artifact to take over (k in use, j used within <rebase-idle>);took over nothing: of n idle artifacts the best keeps x of y B at the same offsets (p %, 50 % needed).busyis split out ofidle.deploy/csi/README.md: the Delta apply: turn an idle artifact on the node into the next variant, writing only what changed #41 cluster results:Verification
BaseBest >= Reusedwhen a base is taken, and below half when none qualifies.Cleanup was verified: no mounts, leases or files left, and the CSIDriver is deleted.
Compatibility and limits
Related Issue
Closes #49
🤖 Generated with Claude Code