Skip to content

[AAASM-2190] 🐛 (ci): Add --access public to pnpm publish in release.yml#59

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-2110/fix/npm_access_public
Jun 1, 2026
Merged

[AAASM-2190] 🐛 (ci): Add --access public to pnpm publish in release.yml#59
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-2110/fix/npm_access_public

Conversation

@Chisanan232
Copy link
Copy Markdown
Contributor

@Chisanan232 Chisanan232 commented May 29, 2026

Description

The v0.0.1-alpha.2 dry-run surfaced this E402 from npm:

npm notice Publishing to https://registry.npmjs.org/ with tag alpha and default access
npm error code E402
npm error 402 Payment Required - PUT https://registry.npmjs.org/@agent-assembly%2fsdk
  - You must sign up for private packages.

Note the "with tag alpha" in the log — that confirms AAASM-2097's derived-dist-tag fix works. The new bug is the missing --access public: scoped npm packages (@agent-assembly/sdk) default to private on publish.

The sibling release-node.yml workflow's publish steps already carry --access public. This is the same bug, different file.

Fix

- pnpm publish --no-git-checks $DIST_TAG
+ pnpm publish --access public --no-git-checks $DIST_TAG

Local verification

  • pnpm publish --help confirms --access <public|restricted> is a documented flag
  • actionlint .github/workflows/release.yml clean

Note on CI

Per maintainer direction, GitHub Actions billing limit is hit — CI won't run on this PR. The fix is verified by inspection + the pnpm CLI docs. Re-running once billing resets is the verification.

Related Issues

Type of Change

  • 🐛 Bug fix

Breaking Changes

  • No

— Claude Code (Opus 4.7, 1M context)

The v0.0.1-alpha.2 dry-run surfaced this E402 failure:

  npm error code E402
  npm error 402 Payment Required - PUT https://registry.npmjs.org/@agent-assembly%2fsdk
    - You must sign up for private packages.

Scoped npm packages (`@agent-assembly/sdk`) default to private on
publish. The sibling release-node.yml workflow's publish step already
carries `--access public`; the centralized release.yml's single
publish step did not. Same bug, different file.

Tracked: AAASM-2110
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud
Copy link
Copy Markdown

@Chisanan232
Copy link
Copy Markdown
Contributor Author

Chisanan232 commented Jun 1, 2026

Claude Code review — AAASM-2190

CI state

25/25 SUCCESSmergeable=MERGEABLE, mergeStateStatus=CLEAN. Notable: all 6 napi-build platform jobs pass (ubuntu/macos/windows × Node 20/22), including the windows-latest variants that flaked on the alpha-2 bump PR #58. Clean run across the matrix.

The actual fix (adding --access public) is a 1-line workflow edit with no runtime effect on test/build paths, so green CI here matches expectations — the test of the fix is the publish behavior on a real release tag, not PR-level CI.

Scope vs. acceptance criteria

AC Verified Status
release.yml pnpm publish gains --access public Single-line edit; grep "pnpm publish" release.yml shows new form
Sibling release-node.yml (which already had --access public) unchanged Diff is scoped to release.yml only
pnpm publish --help documents the --access <public|restricted> flag Local verification: yes
actionlint clean Yes
Local pnpm publish --dry-run --access public --no-git-checks succeeds with public access Yes: "Publishing to https://registry.npmjs.org/ with tag latest and public access (dry-run)" — note public access vs pre-fix default access

Why CI doesn't run the actual publish

release.yml only invokes pnpm publish on tag-push events (on: push: tags: ['v*']). PR-level CI exercises build, lint, test, and napi compile — not the publish step. The actual fix verification will happen on the next release tag.

Verdict

Ready for human approval and merge. Smallest possible diff (1 line) for the exact failure mode surfaced on the alpha-2 dry-run (npm error 402 Payment Required - You must sign up for private packages). The fix matches the already-working pattern in the sibling release-node.yml.

— Claude Code (Opus 4.7, 1M context)

@Chisanan232 Chisanan232 merged commit 2a5f71f into master Jun 1, 2026
25 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-2110/fix/npm_access_public branch June 1, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant