Add Target param to set EnvironmentURL on a deployment Status Update#6
Open
eliotstocker wants to merge 5 commits intoahume:masterfrom
Open
Add Target param to set EnvironmentURL on a deployment Status Update#6eliotstocker wants to merge 5 commits intoahume:masterfrom
eliotstocker wants to merge 5 commits intoahume:masterfrom
Conversation
Owner
|
@eliotstocker Do you mind sorting out these conflicts, and I'll merge this. The |
Author
|
yeah cool, i think i want to switch to a newer github output anyway, ill do a bit of work on this and update the PR |
eliotstocker
force-pushed
the
master
branch
from
45451dc to
496b4cf
Compare
eliotstocker
changed the title
ahume
reviewed
Sep 17, 2019
| } | ||
|
|
||
| if request.Params.Target != "" { | ||
| newStatus.EnvironmentURL = github.String(request.Params.Target) |
Owner
There was a problem hiding this comment.
This seems to conflate target and environment? Should the Params field also be EnvironmentURL?
Author
There was a problem hiding this comment.
sure, i was originally doing this for TargetUrl and then they did the old api update on me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this our concourse pipeline can set the URL for the deployed target when the deployment is complete
Also updated reflectutil as i was having some compilation issues