Close UDP socket after communicating with NTPServer#6
Open
sgenov wants to merge 1 commit intoaharshac:masterfrom
Open
Close UDP socket after communicating with NTPServer#6sgenov wants to merge 1 commit intoaharshac:masterfrom
sgenov wants to merge 1 commit intoaharshac:masterfrom
Conversation
We should close the socket after using it. There is no reason to keep it open. If we want to destroy the first EasyNTPClient instance and then create another one later on, the socket will be taken. This will result in a failure to "ntp->begin(123)", which make getServerTime return 0 This change cleans after the call is done.
|
For this patch to work you have to remove the keyword 'static' from line 43 on EasyNTPClient.cpp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should close the socket after using it. There is no reason to keep it open.
If we want to destroy the first EasyNTPClient instance and then create another one later on, the socket will be taken.
This will result in a failure to "ntp->begin(123)", which makes getServerTime return 0
This change cleans after the call is done.