Skip to content

fix: dedupe assistant response history #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casey-brooks wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: dedupe assistant response history #1359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
022dec5
fix(llm): dedupe assistant response history
casey-brooks Feb 28, 2026
0bf2337
test(platform-server): reproduce second llm input
casey-brooks Feb 28, 2026
68a6ddd
test(platform-server): add agent full-flow duplication tests
casey-brooks Feb 28, 2026
d6d6303
test(platform-server): compare persisted response payloads
casey-brooks Feb 28, 2026
ea941e7
test(platform-server): reproduce mixed response duplication
casey-brooks Feb 28, 2026
7018da0
test(platform-server): cover duplicate tool call cases
casey-brooks Mar 1, 2026
7ebc0cd
fix: filter empty assistant outputs with tool calls
casey-brooks Mar 1, 2026
85c5c57
refactor(llm): simplify load merge assertions
casey-brooks Mar 1, 2026
437938e
test: assert deterministic llm flattening
casey-brooks Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions packages/llm/src/llm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,20 @@ export class LLM {
constructor(private openAI: OpenAI) {}

async call(params: { model: string; input: Array<LLMInput>; tools?: Array<FunctionTool> }) {
const flattenInput = params.input
.map((m) => {
if (m instanceof ResponseMessage) {
return m.output //
.map((o) => o.toPlain());
}
return m.toPlain();
})
.flat();
const flattenInput = params.input.flatMap((m) => {
if (m instanceof ResponseMessage) {
const outputMessages = m.output;
const containsToolCall = outputMessages.some((entry) => entry instanceof ToolCallMessage);
return outputMessages
.filter((entry) => {
if (!containsToolCall) return true;
if (!(entry instanceof AIMessage)) return true;
return entry.text.trim().length > 0;
})
.map((entry) => entry.toPlain());
}
return [m.toPlain()];
});

const toolDefinitions = params.tools?.map((tool) => tool.definition());

Expand Down
Loading
Loading