Conversation
isoos
requested changes
Nov 5, 2020
| @@ -0,0 +1,308 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Please don't check in this file.
| @@ -1,40 +0,0 @@ | |||
| import 'package:cron/cron.dart'; | |||
Contributor
There was a problem hiding this comment.
Why did you delete this? I'd expect more tests, not less...
| part of '../cron.dart'; | ||
|
|
||
| /// The cron schedule. | ||
| class Schedule { |
Contributor
There was a problem hiding this comment.
I can see that some parts of the library can be moved out, but I see very little reason to do it for all small class. Please let's not move everything around, as it is hard to assess the actual diff of the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special characters (?, L) can now be passed to the parser.
A 7th attribute can also be passed that represents the year.
TODO