Skip to content

Use neutral identifiers in the challenge fixtures - #138

Merged
vvillait88 merged 1 commit into
mainfrom
test/neutral-challenge-fixtures
Oct 10, 2026
Merged

vvillait88 merged 1 commit into
mainfrom
test/neutral-challenge-fixtures

Conversation

@vvillait88

Copy link
Copy Markdown
Contributor

Summary

The stripe/charge and solana/charge fixtures in tests/www-authenticate.test.ts were captured from a store that is being shut down. The realm and the store-specific identifiers in the encoded requests (the Stripe network profile and the Solana recipient) are now neutral placeholders. Everything the tests assert is unchanged: amount, currency, decimals and payment method types.

Type of change

  • Bug fix (no breaking change)
  • New feature (no breaking change)
  • Breaking change (existing callers must update)
  • Docs, tests, or internal maintenance only

Public API

None.

Test plan

bun run lint exits 0 and bun run test passes (the file's 10 tests, and the full suite). No release: nothing shipped changes.

Checklist

  • Tests cover the new behavior, and the suite passes locally
  • Lint, format, and type checks pass
  • Docs and README examples updated if the public surface changed (no public surface change)
  • No secrets, credentials, or personal data in the diff or the tests

@vvillait88
vvillait88 merged commit 463c727 into main Oct 10, 2026
9 checks passed
@vvillait88
vvillait88 deleted the test/neutral-challenge-fixtures branch October 10, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant