Repository navigation
Use neutral identifiers in the challenge fixtures - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The stripe/charge and solana/charge fixtures in
tests/www-authenticate.test.tswere captured from a store that is being shut down. The realm and the store-specific identifiers in the encoded requests (the Stripe network profile and the Solana recipient) are now neutral placeholders. Everything the tests assert is unchanged: amount, currency, decimals and payment method types.Type of change
Public API
None.
Test plan
bun run lintexits 0 andbun run testpasses (the file's 10 tests, and the full suite). No release: nothing shipped changes.Checklist