fix(schema): allow SLSA Level 0 for software-only platforms (TRACE v0.2)#21
Open
harshnair75567-cloud wants to merge 3 commits into
Open
fix(schema): allow SLSA Level 0 for software-only platforms (TRACE v0.2)#21harshnair75567-cloud wants to merge 3 commits into
harshnair75567-cloud wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.2 added support for slsa_level: 0 (software-only platforms, no hardware attestation), but the schema, tr_sca.py, and the test suite were never updated to match — so a valid Level 0 record currently gets rejected.
This PR fixes that:
Didn't need to touch test_level0_negative.py — it already checks that 4 and -1 get rejected, and this change doesn't affect either bound, just adds 0 as a new valid floor.