Skip to content

fix(cli): session not found names the owning profile - #392

Open
ankitranjan7 wants to merge 1 commit into
mainfrom
fix/session-profile-not-found
Open

fix(cli): session not found names the owning profile#392
ankitranjan7 wants to merge 1 commit into
mainfrom
fix/session-profile-not-found

Conversation

@ankitranjan7

Copy link
Copy Markdown
Contributor

Description

Closes #388. Related to #377 (profile create / unknown --profile on create).

session close <id> without the owning --profile currently says Session not found and points at the selected/default profile. If that id exists on another profile, the error now names --profile <owner> and the close/list commands to retry.

session list table includes profileId. List remains per-profile; empty output already names the profile.

Type of Change

  • 🐛 Bug fix

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • If I edited skill-src/, I ran make build and committed skills/
npx vitest run --project unit src/skills.test.ts src/browser/sessions.test.ts src/session-docs-sync.test.ts: 28 passed

When the Session id exists on another profile, SESSION_NOT_FOUND names
that --profile. session list includes profileId. List remains per profile.

Closes #388
@github-actions

Copy link
Copy Markdown
Contributor

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

This review is advisory and does not block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: session commands without --profile should name the owning profile

1 participant